Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new ListRolesApi #64

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Conversation

lifosmin
Copy link

@lifosmin lifosmin commented Sep 1, 2023

lifosmin and others added 2 commits August 31, 2023 13:57
* feat: Add filter q, account_type for litAppeals and listGrants and added getTotalCount

* chore: added testing for total count

* chore: fix testing

* chore: fix test total

* chore: fix test mock appeal and grant

* chore: fix test mock user appeal and grant

* chore: fix test coverage

* chore: fix test coverage 2

* chore: fix test coverage 3

* chore: resolve comments

* test: resolve comments

* test: fix testing

---------

Co-authored-by: Lifosmin Simon <[email protected]>
core/grant/service.go Outdated Show resolved Hide resolved
core/grant/service.go Outdated Show resolved Hide resolved
api/handler/v1beta1/grant_test.go Show resolved Hide resolved
api/handler/v1beta1/grant_test.go Show resolved Hide resolved
api/handler/v1beta1/grant_test.go Outdated Show resolved Hide resolved
core/grant/service.go Outdated Show resolved Hide resolved
core/grant/service_test.go Show resolved Hide resolved
internal/store/postgres/grant_repository.go Outdated Show resolved Hide resolved
internal/store/postgres/grant_repository_test.go Outdated Show resolved Hide resolved
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the proton commit in the Makefile and run make proto again

internal/store/postgres/grant_repository_test.go Outdated Show resolved Hide resolved
@rahmatrhd rahmatrhd merged commit b7406c9 into goto:main Sep 12, 2023
2 checks passed
rahmatrhd pushed a commit that referenced this pull request Sep 14, 2023
* feat: Added new ListRolesApi

* chore: Changed input and created error handling when receiving id

* test: fix

* test: fix testing

* fix: testing

* fix: makefile

---------

Co-authored-by: Lifosmin Simon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants