Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept base64 encoded credentials in policy.IAM config #61

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

rahmatrhd
Copy link
Member

No description provided.

@rahmatrhd rahmatrhd self-assigned this Aug 22, 2023
@mabdh
Copy link
Member

mabdh commented Aug 22, 2023

Rather than doing this, why don't we add a new field for CredentialsJSONBase64 and mark the field CredentialsJSON as deprecated and we will deprecate it for good starting a certain version?

@rahmatrhd rahmatrhd requested a review from mabdh August 22, 2023 10:01
@rahmatrhd rahmatrhd requested a review from mabdh August 23, 2023 03:56
@rahmatrhd rahmatrhd merged commit ad1350e into main Aug 23, 2023
4 checks passed
@rahmatrhd rahmatrhd deleted the fix-inactive-grants-revocation branch September 8, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants