-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate otel collector in guardian #173
Conversation
ca64c8d
to
659ed6e
Compare
659ed6e
to
212cf5c
Compare
internal/server/server.go
Outdated
authInterceptor, | ||
grpc_logrus.UnaryServerInterceptor(logrusEntry), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reason to put this after the auth interceptor? if none we can put it back like previous order as it was
internal/server/server.go
Outdated
grpc.WithDefaultCallOptions( | ||
grpc.MaxCallRecvMsgSize(config.GRPC.MaxCallRecvMsgSize), | ||
grpc.MaxCallSendMsgSize(config.GRPC.MaxCallSendMsgSize), | ||
), | ||
grpc.WithDisableRetry(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this needed for?
cli/root.go
Outdated
} | ||
|
||
defer func() { | ||
if err := shutdownOtel(); err != nil { | ||
log.Printf("telemetry is disabled: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Printf("telemetry is disabled: %v", err) | |
log.Printf("failed to terminate telemetery: %v\n", err) |
No description provided.