feat: integrate otel collector in guardian #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifosmin
force-pushed
the
otel_collector
branch
from
ca64c8d
to
659ed6e
Compare
added 12 commits
September 11, 2024 12:03
lifosmin
force-pushed
the
otel_collector
branch
from
659ed6e
to
212cf5c
Compare
rahmatrhd
reviewed
Sep 17, 2024
rahmatrhd
reviewed
Sep 18, 2024
rahmatrhd
reviewed
Sep 18, 2024
rahmatrhd
reviewed
Sep 18, 2024
rahmatrhd
reviewed
Sep 18, 2024
internal/server/server.go
Outdated
| authInterceptor, | ||
| grpc_logrus.UnaryServerInterceptor(logrusEntry), |
There was a problem hiding this comment.
is there any reason to put this after the auth interceptor? if none we can put it back like previous order as it was
added 2 commits
September 18, 2024 13:56
rahmatrhd
reviewed
Sep 18, 2024
internal/server/server.go
Outdated
| grpc.WithDefaultCallOptions( | ||
| grpc.MaxCallRecvMsgSize(config.GRPC.MaxCallRecvMsgSize), | ||
| grpc.MaxCallSendMsgSize(config.GRPC.MaxCallSendMsgSize), | ||
| ), | ||
| grpc.WithDisableRetry(), |
rahmatrhd
reviewed
Sep 19, 2024
cli/root.go
Outdated
| } | ||
|
|
||
| defer func() { | ||
| if err := shutdownOtel(); err != nil { | ||
| log.Printf("telemetry is disabled: %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Printf("telemetry is disabled: %v", err) | |
| log.Printf("failed to terminate telemetery: %v\n", err) |
rahmatrhd
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.