chore: fix test total

goto · Aug 29, 2023 · e220c2e · e220c2e
1 parent 9cc9364
commit e220c2e
Show file tree

Hide file tree

Showing 4 changed files with 53 additions and 25 deletions.
diff --git a/api/handler/v1beta1/appeal_test.go b/api/handler/v1beta1/appeal_test.go
@@ -288,6 +288,7 @@ func (s *GrpcHandlersSuite) TestListAppeals() {
 					UpdatedAt: timestamppb.New(timeNow),
 				},
 			},
+			Total: 1,
 		}
 		s.appealService.EXPECT().Find(mock.AnythingOfType("*context.emptyCtx"), expectedFilters).
 			Return(expectedAppeals, nil).Once()

diff --git a/api/handler/v1beta1/grant_test.go b/api/handler/v1beta1/grant_test.go
@@ -66,6 +66,7 @@ func (s *GrpcHandlersSuite) TestListGrants() {
 					},
 				},
 			},
+			Total: 1,
 		}
 		expectedFilter := domain.ListGrantsFilter{
 			Statuses:     []string{"test-status"},

diff --git a/core/appeal/service_test.go b/core/appeal/service_test.go
@@ -2871,6 +2871,32 @@ func (s *ServiceTestSuite) TestDeleteApprover() {
 	})
 }
 
+func (s *ServiceTestSuite) TestGetAppealsTotalCount() {
+	s.Run("should return error if got error from repository", func() {
+		expectedError := errors.New("repository error")
+		s.mockRepository.EXPECT().
+			GetAppealsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
+			Return(0, expectedError).Once()
+
+		actualCount, actualError := s.service.GetAppealsTotalCount(context.Background(), &domain.ListAppealsFilter{})
+
+		s.Zero(actualCount)
+		s.EqualError(actualError, expectedError.Error())
+	})
+
+	s.Run("should return appeals count from repository", func() {
+		expectedCount := int64(1)
+		s.mockRepository.EXPECT().
+			GetAppealsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
+			Return(expectedCount, nil).Once()
+
+		actualCount, actualError := s.service.GetAppealsTotalCount(context.Background(), &domain.ListAppealsFilter{})
+
+		s.Equal(expectedCount, actualCount)
+		s.NoError(actualError)
+	})
+}
+
 func TestService(t *testing.T) {
 	suite.Run(t, new(ServiceTestSuite))
 }
diff --git a/core/grant/service_test.go b/core/grant/service_test.go
@@ -990,28 +990,28 @@ func (s *ServiceTestSuite) TestDormancyCheck() {
 	})
 }
 
-// func (s *ServiceTestSuite) TestGetGrantsTotalCount() {
-// 	s.Run("should return error if got error from repository", func() {
-// 		expectedError := errors.New("repository error")
-// 		s.mockRepository.EXPECT().
-// 			GetGrantsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
-// 			Return(0, expectedError).Once()
-
-// 		actualCount, actualError := s.service.GetGrantsTotalCount(context.Background(), domain.ListGrantsFilter{})
-
-// 		s.Zero(actualCount)
-// 		s.EqualError(actualError, expectedError.Error())
-// 	})
-
-// 	s.Run("should return Grants count from repository", func() {
-// 		expectedCount := int64(1)
-// 		s.mockRepository.EXPECT().
-// 			GetGrantsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
-// 			Return(expectedCount, nil).Once()
-
-// 		actualCount, actualError := s.service.GetGrantsTotalCount(context.Background(), domain.ListGrantsFilter{})
-
-// 		s.Equal(expectedCount, actualCount)
-// 		s.NoError(actualError)
-// 	})
-// }
+func (s *ServiceTestSuite) TestGetGrantsTotalCount() {
+	s.Run("should return error if got error from repository", func() {
+		expectedError := errors.New("repository error")
+		s.mockRepository.EXPECT().
+			GetGrantsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
+			Return(0, expectedError).Once()
+
+		actualCount, actualError := s.service.GetGrantsTotalCount(context.Background(), domain.ListGrantsFilter{})
+
+		s.Zero(actualCount)
+		s.EqualError(actualError, expectedError.Error())
+	})
+
+	s.Run("should return Grants count from repository", func() {
+		expectedCount := int64(1)
+		s.mockRepository.EXPECT().
+			GetGrantsTotalCount(mock.AnythingOfType("*context.emptyCtx"), mock.Anything).
+			Return(expectedCount, nil).Once()
+
+		actualCount, actualError := s.service.GetGrantsTotalCount(context.Background(), domain.ListGrantsFilter{})
+
+		s.Equal(expectedCount, actualCount)
+		s.NoError(actualError)
+	})
+}