chore: fix test coverage 2

goto · Aug 30, 2023 · dd33abf · dd33abf
1 parent 79b1e6c
commit dd33abf
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 11 deletions.
diff --git a/api/handler/v1beta1/appeal_test.go b/api/handler/v1beta1/appeal_test.go
@@ -33,6 +33,8 @@ func (s *GrpcHandlersSuite) TestListUserAppeals() {
 			ResourceTypes: []string{"test-resource-type"},
 			ResourceURNs:  []string{"test-resource-urn"},
 			OrderBy:       []string{"test-order"},
+			AccountTypes:  []string{"test-account-type"},
+			Q:             "test",
 		}
 		expectedAppeals := []*domain.Appeal{
 			{
@@ -132,6 +134,8 @@ func (s *GrpcHandlersSuite) TestListUserAppeals() {
 			ResourceTypes: []string{"test-resource-type"},
 			ResourceUrns:  []string{"test-resource-urn"},
 			OrderBy:       []string{"test-order"},
+			AccountTypes:  []string{"test-account-type"},
+			Q:             "test",
 		}
 		ctx := context.WithValue(context.Background(), authEmailTestContextKey{}, expectedUser)
 		res, err := s.grpcServer.ListUserAppeals(ctx, req)

diff --git a/internal/store/postgres/appeal_repository_test.go b/internal/store/postgres/appeal_repository_test.go
@@ -130,15 +130,36 @@ func (s *AppealRepositoryTestSuite) TestGetByID() {
 	})
 
 	s.Run("should run query based on filters", func() {
-		dummyAppeal := &domain.Appeal{
-			ResourceID:    s.dummyResource.ID,
-			PolicyID:      s.dummyPolicy.ID,
-			PolicyVersion: s.dummyPolicy.Version,
-			AccountID:     "[email protected]",
-			AccountType:   domain.DefaultAppealAccountType,
-			Role:          "role_test",
-			Permissions:   []string{"permission_test"},
-			CreatedBy:     "[email protected]",
+		timeNowPlusAnHour := time.Now().Add(time.Hour)
+		dummyAppeals := []*domain.Appeal{
+			{
+				ResourceID:    s.dummyResource.ID,
+				PolicyID:      s.dummyPolicy.ID,
+				PolicyVersion: s.dummyPolicy.Version,
+				AccountID:     "[email protected]",
+				AccountType:   domain.DefaultAppealAccountType,
+				Role:          "role_test",
+				Status:        domain.AppealStatusApproved,
+				Permissions:   []string{"permission_test"},
+				CreatedBy:     "[email protected]",
+				Options: &domain.AppealOptions{
+					ExpirationDate: &time.Time{},
+				},
+			},
+			{
+				ResourceID:    s.dummyResource.ID,
+				PolicyID:      s.dummyPolicy.ID,
+				PolicyVersion: s.dummyPolicy.Version,
+				AccountID:     "[email protected]",
+				AccountType:   domain.DefaultAppealAccountType,
+				Status:        domain.AppealStatusCanceled,
+				Role:          "role_test",
+				Permissions:   []string{"permission_test_2"},
+				CreatedBy:     "[email protected]",
+				Options: &domain.AppealOptions{
+					ExpirationDate: &timeNowPlusAnHour,
+				},
+			},
 		}
 		testCases := []struct {
 			filters        *domain.ListAppealsFilter
@@ -149,13 +170,13 @@ func (s *AppealRepositoryTestSuite) TestGetByID() {
 				filters: &domain.ListAppealsFilter{
 					Q: "user",
 				},
-				expectedResult: []*domain.Appeal{dummyAppeal},
+				expectedResult: []*domain.Appeal{dummyAppeals[0], dummyAppeals[1]},
 			},
 			{
 				filters: &domain.ListAppealsFilter{
 					AccountTypes: []string{"x-account-type"},
 				},
-				expectedResult: []*domain.Appeal{dummyAppeal},
+				expectedResult: []*domain.Appeal{dummyAppeals[0], dummyAppeals[1]},
 			},
 		}
 
@@ -166,6 +187,16 @@ func (s *AppealRepositoryTestSuite) TestGetByID() {
 	})
 }
 
+func (s *AppealRepositoryTestSuite) TestGetAppealsTotalCount() {
+
+	s.Run("should return 0", func() {
+		actualResult, actualError := s.repository.GetAppealsTotalCount(context.Background(), &domain.ListAppealsFilter{})
+
+		s.Equal(int64(0), actualResult)
+		s.Nil(actualError)
+	})
+}
+
 func (s *AppealRepositoryTestSuite) TestFind() {
 	timeNowPlusAnHour := time.Now().Add(time.Hour)
 	dummyAppeals := []*domain.Appeal{

diff --git a/internal/store/postgres/approval_repository_test.go b/internal/store/postgres/approval_repository_test.go
@@ -117,6 +117,16 @@ func (s *ApprovalRepositoryTestSuite) TearDownSuite() {
 	}
 }
 
+func (s *ApprovalRepositoryTestSuite) TestGetApprovalsTotalCount() {
+
+	s.Run("should return 0", func() {
+		actualResult, actualError := s.repository.GetApprovalsTotalCount(context.Background(), &domain.ListApprovalsFilter{})
+
+		s.Equal(int64(0), actualResult)
+		s.Nil(actualError)
+	})
+}
+
 func (s *ApprovalRepositoryTestSuite) TestListApprovals() {
 	pendingAppeal := &domain.Appeal{
 		ResourceID:    s.dummyResource.ID,

diff --git a/internal/store/postgres/grant_repository_test.go b/internal/store/postgres/grant_repository_test.go
@@ -120,6 +120,15 @@ func (s *GrantRepositoryTestSuite) TearDownSuite() {
 	}
 }
 
+func (s *GrantRepositoryTestSuite) TestGetGrantsTotalCount() {
+
+	s.Run("should return 0", func() {
+		actualResult, actualError := s.repository.GetGrantsTotalCount(context.Background(), domain.ListGrantsFilter{})
+
+		s.Equal(int64(0), actualResult)
+		s.Nil(actualError)
+	})
+}
 func (s *GrantRepositoryTestSuite) TestList() {
 	expDate := time.Now()
 	dummyGrants := []*domain.Grant{