feat(appeal): use accountID filter to fetch pendingAppeals (#53)

- use accountID filter to fetch pendingAppeals

buf.gen.yaml

@@ -16,4 +16,4 @@ plugins:
     out: api/proto
     opt:
       - paths=source_relative
-      - lang=go
+      - lang=go

core/appeal/service.go

@@ -180,8 +180,10 @@ func (s *Service) Create(ctx context.Context, appeals []*domain.Appeal, opts ...
 	isAdditionalAppealCreation := createAppealOpts.IsAdditionalAppeal
 
 	resourceIDs := []string{}
+	accountIDs := []string{}
 	for _, a := range appeals {
 		resourceIDs = append(resourceIDs, a.ResourceID)
+		accountIDs = append(accountIDs, a.AccountID)
 	}
 	resources, err := s.getResourcesMap(ctx, resourceIDs)
 	if err != nil {
@@ -196,7 +198,10 @@ func (s *Service) Create(ctx context.Context, appeals []*domain.Appeal, opts ...
 		return err
 	}
 
-	pendingAppeals, err := s.getPendingAppealsMap(ctx)
+	pendingAppeals, err := s.getAppealsMap(ctx, &domain.ListAppealsFilter{
+		Statuses:   []string{domain.AppealStatusPending},
+		AccountIDs: accountIDs,
+	})
 	if err != nil {
 		return fmt.Errorf("listing pending appeals: %w", err)
 	}
@@ -777,11 +782,9 @@ func (s *Service) getApproval(ctx context.Context, appealID, approvalID string)
 	return appeal, approval, nil
 }
 
-// getPendingAppealsMap returns map[account_id]map[resource_id]map[role]*domain.Appeal, error
-func (s *Service) getPendingAppealsMap(ctx context.Context) (map[string]map[string]map[string]*domain.Appeal, error) {
-	appeals, err := s.repo.Find(ctx, &domain.ListAppealsFilter{
-		Statuses: []string{domain.AppealStatusPending},
-	})
+// getAppealsMap returns map[account_id]map[resource_id]map[role]*domain.Appeal, error
+func (s *Service) getAppealsMap(ctx context.Context, filters *domain.ListAppealsFilter) (map[string]map[string]map[string]*domain.Appeal, error) {
+	appeals, err := s.repo.Find(ctx, filters)
 	if err != nil {
 		return nil, err
 	}

core/appeal/service_test.go

@@ -905,7 +905,8 @@ func (s *ServiceTestSuite) TestCreate() {
 		s.mockProviderService.On("Find", mock.Anything).Return(providers, nil).Once()
 		s.mockPolicyService.On("Find", mock.Anything).Return(policies, nil).Once()
 		expectedExistingAppealsFilters := &domain.ListAppealsFilter{
-			Statuses: []string{domain.AppealStatusPending},
+			Statuses:   []string{domain.AppealStatusPending},
+			AccountIDs: []string{"[email protected]", "addOnBehalfApprovedNotification-user"},
 		}
 		s.mockRepository.EXPECT().
 			Find(mock.AnythingOfType("*context.emptyCtx"), expectedExistingAppealsFilters).
@@ -1255,7 +1256,8 @@ func (s *ServiceTestSuite) TestCreateAppeal__WithExistingAppealAndWithAutoApprov
 	s.mockProviderService.On("Find", mock.Anything).Return(providers, nil).Once()
 	s.mockPolicyService.On("Find", mock.Anything).Return(policies, nil).Once()
 	expectedExistingAppealsFilters := &domain.ListAppealsFilter{
-		Statuses: []string{domain.AppealStatusPending},
+		Statuses:   []string{domain.AppealStatusPending},
+		AccountIDs: []string{accountID},
 	}
 	s.mockRepository.EXPECT().
 		Find(mock.AnythingOfType("*context.emptyCtx"), expectedExistingAppealsFilters).