fix: use mutex locks while fetching resources in errgroup

- Without the mutex lock, the append resources is not concurrency safe. So use lock while appending to the resources slice
goto · May 3, 2023 · 42fe708 · 42fe708
1 parent 3c37a41
commit 42fe708
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/plugins/providers/bigquery/provider.go b/plugins/providers/bigquery/provider.go
@@ -124,6 +124,7 @@ func (p *Provider) GetResources(pc *domain.ProviderConfig) ([]*domain.Resource,
 	resources := []*domain.Resource{}
 	eg, ctx := errgroup.WithContext(context.TODO())
 	eg.SetLimit(10)
+	var mu sync.Mutex
 
 	datasets, err := client.GetDatasets(ctx)
 	if err != nil {
@@ -137,6 +138,8 @@ func (p *Provider) GetResources(pc *domain.ProviderConfig) ([]*domain.Resource,
 			dataset.ProviderURN = pc.URN
 
 			if containsString(resourceTypes, ResourceTypeDataset) {
+				mu.Lock()
+				defer mu.Unlock()
 				resources = append(resources, dataset)
 			}