Add Dialer.ProxyConnectHeader #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngCr3at1on
suggested changes
Sep 8, 2020
| @@ -274,7 +277,7 @@ func (d *Dialer) DialContext(ctx context.Context, urlStr string, requestHeader h | |||
| return nil, nil, err | |||
| } | |||
| if proxyURL != nil { | |||
| dialer, err := proxy_FromURL(proxyURL, netDialerFunc(netDial)) | |||
| dialer, err := proxy_FromURL(proxyURL, &netDialer{d.ProxyConnectHeader, netDial}) | |||
There was a problem hiding this comment.
Should check if the header is set before using it.
There was a problem hiding this comment.
Custom header information, can be empty
proxy.go
Outdated
| } | ||
|
|
||
| func init() { | ||
| proxy_RegisterDialerType("http", func(proxyURL *url.URL, forwardDialer proxy_Dialer) (proxy_Dialer, error) { | ||
| return &httpProxyDialer{proxyURL: proxyURL, forwardDial: forwardDialer.Dial}, nil | ||
| p, _ := forwardDialer.(*netDialer) |
There was a problem hiding this comment.
We really should not just discard errors here.
AllenX2018
force-pushed
the
fix-issue-479
branch
from
7ce4db9
to
aa46640
Compare
|
LGTM but someone else must approve. Just a quick comment: force pushing on a PR makes it difficult to review your new changes to the PR; I'd suggest just pushing followup commits and if you want to squash them after review that's a good idea. In this case it was easy enough to scroll through and find the change but it can be quite cumbersome in large PRs. |
|
Yes, thanks for the kind reminder |
|
LGTM - if the merge conflicts can be resolved then we can merge this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479. Add a field
ProxyConnectHeaderinDialerfor user to costomize the proxy headers