Don't propagate anchors to "mark" composite glyphs with anchors #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
changed the title
anthrotype
force-pushed
the
no-marks-anchor-propagation
branch
2 times, most recently
from
9141d2c
to
1b97f1f
Compare
This is meant to match Glyphs.app's logic, see #802 (A similar fix should be added to glyphsLib's anchor_propagation.py until the latter is superseded by the ufo2ft filter)
anthrotype
force-pushed
the
no-marks-anchor-propagation
branch
from
1b97f1f
to
b5830b8
Compare
|
@simoncozens can you check if this is what you expected? I borrowed the test case from #802. I know this doesn't directly fix your problem -- since you're actually using glyphsLib to propagate the anchors and not this ufo2ft filter, but eventually we want to consolidate the two (i.e. stop doing it in glyphsLib) so this would be a step towards that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to match Glyphs.app's anchors propagation logic whereby if a composite glyph is classified as a "mark" and it already has some anchors, then anchors from its components do not get propagated to it, otherwise Bad Things(tm) happen
see #802
(A similar fix should be added to glyphsLib's anchor_propagation.py until the latter is superseded by the ufo2ft filter ... eventually)