Fix InDesign default composer kerning when mixing two scripts with a language selected #788
+33
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picture explanation of the issue:
It seems that the default composer prefers to trust the Language setting of the text, as opposed to segmenting the text into per-script runs, and only applies features registered in the script of the selected language? Just guessing, no idea how it really works.
It's sort of a regression from previous ufo2ft without kern splitting, because then all LTR kerning was together in one big lookup anyway.
This one feels a bit like walking backwards from the nice split-by-script kerning, but in the spirit of having fonts that work out of box even in sub-optimal settings, we're planning to use this fix anyway.
This could maybe go behind a flag? It's kind of garbage