Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate anchors filter #514

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/ufo2ft/filters/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from .decomposeTransformedComponents import DecomposeTransformedComponentsFilter
from .explodeColorLayerGlyphs import ExplodeColorLayerGlyphsFilter
from .flattenComponents import FlattenComponentsFilter
from .optimizeAnchors import OptimizeAnchorsFilter
from .propagateAnchors import PropagateAnchorsFilter
from .removeOverlaps import RemoveOverlapsFilter
from .sortContours import SortContoursFilter
Expand All @@ -23,6 +24,7 @@
"DecomposeTransformedComponentsFilter",
"ExplodeColorLayerGlyphsFilter",
"FlattenComponentsFilter",
"OptimizeAnchorsFilter",
"PropagateAnchorsFilter",
"RemoveOverlapsFilter",
"SortContoursFilter",
Expand Down
35 changes: 35 additions & 0 deletions Lib/ufo2ft/filters/optimizeAnchors.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
from ufo2ft.filters.transformations import TransformationsFilter
from fontTools.misc.transform import Identity, Transform
import logging

log = logging.getLogger(__name__)


class OptimizeAnchorsFilter(TransformationsFilter):
def set_context(self, font, glyphSet):
# Skip over transformations filter to base filter
return super(TransformationsFilter, self).set_context(font, glyphSet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to explicitly call the BaseFilter.set_context(self, font, glyphSet) since that is what you are after.


def filter(self, glyph):
if len(glyph.anchors) == 0 or any(
not (a.name.startswith("_")) for a in glyph.anchors
):
# We're a base!
return False

# More sanity checks: skip over spacing marks
if glyph.width != 0:
return False
# Also skip over marks which are deliberately positioned over the
# previous glyphs
if glyph.getBounds().xMax < 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a heuristic as to guess whether a mark was "deliberately positioned over the previous glyph", I think this is a bit too fragile. It's conceivable that the xMax still be >= 0 while the mark being intentionally designed to fall on top of another (e.g. narrow) base glyph

return False

# We are a mark glyph with (at least) one attachment point.
theanchor = glyph.anchors[0]
self.context.matrix = Identity.translate(-theanchor.x, -theanchor.y)
log.warn(
"Transforming glyph %s to zero anchor %s: %s"
% (glyph.name, theanchor.name, self.context.matrix)
)
return super().filter(glyph)