Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten components option #438

Merged
merged 8 commits into from
Dec 10, 2020
Merged

Flatten components option #438

merged 8 commits into from
Dec 10, 2020

Conversation

simoncozens
Copy link
Contributor

Add option to compileTTF to flatten nested components. See fonttools/fontbakery#2961

@simoncozens simoncozens mentioned this pull request Dec 7, 2020
Merged
@m4rc1e m4rc1e mentioned this pull request Dec 9, 2020
Merged
anthrotype
anthrotype reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would only work for static TTFs (built with compileTTF), but not also for interpolatable TTFs nor for VFs. Shouldn't the option also apply to the latter?

Lib/ufo2ft/preProcessor.py Outdated Show resolved Hide resolved
@simoncozens
Copy link
Contributor Author

There we go. I somehow missed the DecomposeComponents filter in TTFInterpolatablePreProcessor, so I thought we needed to leave components alone for variable fonts. (I was confusing them with overlapping outlines...)

@anthrotype
Copy link
Member

I think we should decompose mixed glyphs before flattening nested components

anthrotype
anthrotype reviewed Dec 10, 2020
View reviewed changes
Lib/ufo2ft/__init__.py Outdated Show resolved Hide resolved
anthrotype
anthrotype approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthrotype
Copy link
Member

slightly (un)related, but it would be nice if glyphsLib automatically added the filter to the generated UFO libs when the equivalent custom parameter (which I forgot the name but I'm pretty sure exists) is set in the .glyphs source

@anthrotype anthrotype merged commit c12bac8 into googlefonts:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @anthrotype