Don't allow guideline selection, if they are hidden.

src/fontra/views/editor/editor.js

@@ -131,10 +131,24 @@ export class EditorController {
       async (...args) => await this.editListenerCallback(...args)
     );
 
+    this.visualizationLayers = new VisualizationLayers(
+      visualizationLayerDefinitions,
+      this.isThemeDark
+    );
+
+    this.visualizationLayersSettings = newVisualizationLayersSettings(
+      this.visualizationLayers
+    );
+    this.visualizationLayersSettings.addListener((event) => {
+      this.visualizationLayers.toggle(event.key, event.newValue);
+      this.canvasController.requestUpdate();
+    }, true);
+
     this.sceneController = new SceneController(
       this.fontController,
       canvasController,
-      applicationSettingsController
+      applicationSettingsController,
+      this.visualizationLayersSettings
     );
 
     this.sceneSettingsController = this.sceneController.sceneSettingsController;
@@ -164,19 +178,6 @@ export class EditorController {
 
     this.cjkDesignFrame = new CJKDesignFrame(this);
 
-    this.visualizationLayers = new VisualizationLayers(
-      visualizationLayerDefinitions,
-      this.isThemeDark
-    );
-
-    this.visualizationLayersSettings = newVisualizationLayersSettings(
-      this.visualizationLayers
-    );
-    this.visualizationLayersSettings.addListener((event) => {
-      this.visualizationLayers.toggle(event.key, event.newValue);
-      this.canvasController.requestUpdate();
-    }, true);
-
     const sceneView = new SceneView(this.sceneModel, (model, controller) =>
       this.visualizationLayers.drawVisualizationLayers(model, controller)
     );
@@ -2782,7 +2783,10 @@ export class EditorController {
       }
     }
 
-    if (selectGuidelines) {
+    if (
+      selectGuidelines &&
+      this.visualizationLayersSettings.model["fontra.guidelines"]
+    ) {
       for (const guidelineIndex of range(positionedGlyph.glyph.guidelines.length)) {
         const guideline = positionedGlyph.glyph.guidelines[guidelineIndex];
         if (!guideline.locked) {

src/fontra/views/editor/scene-controller.js

@@ -36,7 +36,12 @@ import { translate, translatePlural } from "/core/localization.js";
 import { dialog, message } from "/web-components/modal-dialog.js";
 
 export class SceneController {
-  constructor(fontController, canvasController, applicationSettingsController) {
+  constructor(
+    fontController,
+    canvasController,
+    applicationSettingsController,
+    visualizationLayersSettings
+  ) {
     this.canvasController = canvasController;
     this.applicationSettings = applicationSettingsController.model;
     this.fontController = fontController;
@@ -53,7 +58,8 @@ export class SceneController {
     this.sceneModel = new SceneModel(
       fontController,
       this.sceneSettingsController,
-      isPointInPath
+      isPointInPath,
+      visualizationLayersSettings
     );
 
     this.selectedTool = undefined;

src/fontra/views/editor/scene-model.js

@@ -21,11 +21,17 @@ import * as vector from "../core/vector.js";
 import { loaderSpinner } from "/core/loader-spinner.js";
 
 export class SceneModel {
-  constructor(fontController, sceneSettingsController, isPointInPath) {
+  constructor(
+    fontController,
+    sceneSettingsController,
+    isPointInPath,
+    visualizationLayersSettings
+  ) {
     this.fontController = fontController;
     this.sceneSettingsController = sceneSettingsController;
     this.sceneSettings = sceneSettingsController.model;
     this.isPointInPath = isPointInPath;
+    this.visualizationLayersSettings = visualizationLayersSettings;
     this.hoveredGlyph = undefined;
     this._glyphLocations = {}; // glyph name -> glyph location
     this.longestLineLength = 0;
@@ -681,6 +687,10 @@ export class SceneModel {
   }
 
   guidelineSelectionAtPoint(point, size, parsedCurrentSelection) {
+    if (!this.visualizationLayersSettings.model["fontra.guidelines"]) {
+      // If guidelines are hidden, don't allow selection
+      return new Set();
+    }
     const positionedGlyph = this.getSelectedPositionedGlyph();
     if (!positionedGlyph) {
       return new Set();