Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation keys #1764

Merged
merged 67 commits into from
Nov 13, 2024
Merged

Conversation

ollimeier
Copy link
Collaborator

@ollimeier ollimeier commented Nov 4, 2024

Fixes #1763 and fixes #1752

This is the first part of the rework for missing translations.

I split it up, because it may get messy otherwise. This PR includes commits based on each file (Related Glyphs, Glyph Note, Shortcuts panel, Sources Panel and Status Definitions panel). But the next work might not be structured this nicely anymore, because the strings are all over the place.
So, I created another branch where I first marked the missing translations:
https://github.com/googlefonts/fontra/tree/issue-1752-missing-translation-keys-2

@ollimeier
Copy link
Collaborator Author

@justvanrossum I am wondering if we really want to have a unique translation for undo (always)?

Here an example:
We have undoLabel: "align left", this would require a new translation key, but we have already a translation for 'Align left' via key: sidebar.selection-transformation.align.left.
This is same for many other undo strings. It's basically just set in 'lowercase'.
Do you think it would make sense to reuse some translation keys and accept it's not lowercase? We could also make it always convert to lowercase, but I am not sure if this would work (always) for other languages except English?
But doubling the keys also does not feel correct.

Would be great to get you feedback and advice. Thanks a lot in advance.

@ollimeier ollimeier force-pushed the issue-1752-missing-translation-keys branch 2 times, most recently from d2de642 to 40e5fef Compare November 6, 2024 00:40
@ollimeier ollimeier changed the title Add missing translation keys (part 1) Add missing translation keys Nov 6, 2024
@ollimeier
Copy link
Collaborator Author

As discussed yesterday, this translation key update is almost complete, but we decided to leave it as it is, so that we do not spend too much time on translations and can focus on other features.

src/fontra/client/web-components/plugin-manager.js Outdated Show resolved Hide resolved
src/fontra/views/editor/edit-tools-pointer.js Outdated Show resolved Hide resolved
src/fontra/views/editor/editor.js Outdated Show resolved Hide resolved
src/fontra/views/editor/editor.js Outdated Show resolved Hide resolved
src/fontra/views/editor/editor.js Outdated Show resolved Hide resolved
src/fontra/views/editor/panel-related-glyphs.js Outdated Show resolved Hide resolved
src/fontra/views/editor/panel-selection-info.js Outdated Show resolved Hide resolved
src/fontra/views/editor/panel-selection-info.js Outdated Show resolved Hide resolved
src/fontra/views/editor/panel-selection-info.js Outdated Show resolved Hide resolved
@ollimeier ollimeier force-pushed the issue-1752-missing-translation-keys branch from bfda384 to fc4534c Compare November 13, 2024 00:12
@justvanrossum justvanrossum merged commit 4383a27 into main Nov 13, 2024
5 checks passed
@justvanrossum justvanrossum deleted the issue-1752-missing-translation-keys branch November 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants