Use "glyph-search" panel instead of adding glyphsSearch to editorCont…

…roller
googlefonts · Oct 31, 2024 · a0a66e6 · a0a66e6
1 parent f32ee00
commit a0a66e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/fontra/views/editor/editor.js b/src/fontra/views/editor/editor.js
@@ -2838,7 +2838,8 @@ export class EditorController {
   }
 
   async doSelectPreviousNextGlyph(selectPrevious) {
-    const filteredGlyphItems = this.glyphsSearch.filteredGlyphItems;
+    const panel = this.getSidebarPanel("glyph-search");
+    const filteredGlyphItems = panel.glyphsSearch.filteredGlyphItems;
     const glyphNames = filteredGlyphItems.map((x) => x.glyphName);
 
     const selectedGlyphName = this.sceneSettings.selectedGlyphName;

diff --git a/src/fontra/views/editor/panel-glyph-search.js b/src/fontra/views/editor/panel-glyph-search.js
@@ -18,16 +18,15 @@ export default class GlyphSearchPanel extends Panel {
 
   constructor(editorController) {
     super(editorController);
-    const glyphsSearch = this.contentElement.querySelector("#glyphs-search");
-    editorController.glyphsSearch = glyphsSearch;
-    glyphsSearch.addEventListener("selectedGlyphNameChanged", (event) =>
+    this.glyphsSearch = this.contentElement.querySelector("#glyphs-search");
+    this.glyphsSearch.addEventListener("selectedGlyphNameChanged", (event) =>
       this.glyphNameChangedCallback(event.detail)
     );
     this.editorController.fontController.addChangeListener({ glyphMap: null }, () => {
-      glyphsSearch.updateGlyphNamesListContent();
+      this.glyphsSearch.updateGlyphNamesListContent();
     });
     this.editorController.fontController.ensureInitialized.then(() => {
-      glyphsSearch.glyphMap = this.editorController.fontController.glyphMap;
+      this.glyphsSearch.glyphMap = this.editorController.fontController.glyphMap;
     });
   }