Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support component flattening #268

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Support component flattening #268

merged 5 commits into from
Apr 20, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Apr 18, 2023 •
edited
Loading

Improves Oswald build alignment with fontmake as run by gftools. See #250 (comment).

Builds on #267.

Once this plus the PRs it builds on are merged the largest source of difference in glyf for Oswald is that we don't remove implicit on-curves.

@rsheeter rsheeter changed the base branch from main to cflag April 18, 2023 21:49
@rsheeter rsheeter changed the title [wip] Support component flattening Support component flattening Apr 19, 2023
@rsheeter rsheeter marked this pull request as ready for review April 19, 2023 00:14
anthrotype
anthrotype reviewed Apr 19, 2023
View reviewed changes
fontc/src/args.rs Outdated Show resolved Hide resolved
anthrotype
anthrotype reviewed Apr 19, 2023
View reviewed changes
fontir/src/glyph.rs Outdated Show resolved Hide resolved
anthrotype
anthrotype approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flattening logic LGTM, but would prefer if disabled by default

@anthrotype
Copy link
Member

it just occurred to me that, after flattening components, we may end up with orphan glyphs that are no longer used by composite glyphs and may also have no direct cmapping nor be substituted to from GSUB rules so they are basically dead weight, which a subsetter --unicodes='*' would surely get rid of, but maybe the compiler could/should be smarter and avoid them to be left in.
see googlefonts/ufo2ft#692

@rsheeter @anthrotype
Update fontir/src/glyph.rs
7c264d4 
Co-authored-by: Cosimo Lupo <[email protected]>
@rsheeter rsheeter mentioned this pull request Apr 20, 2023
Open
@rsheeter
Copy link
Contributor Author

after flattening components, we may end up with orphan glyphs ...

Good point, filed #270

Base automatically changed from cflag to main April 20, 2023 17:17
@rsheeter rsheeter merged commit 016e727 into main Apr 20, 2023
@rsheeter rsheeter deleted the flatten branch April 20, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Compile Oswald and compare to fontmake
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @anthrotype