chore: add artifacts in gapic-bom in allow list (#2402)

googleapis · Jan 19, 2024 · f22c012 · f22c012
1 parent c0a3c1c
commit f22c012
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/...s/unmanaged-dependency-check/src/main/java/com/google/cloud/UnmanagedDependencyCheck.java b/...s/unmanaged-dependency-check/src/main/java/com/google/cloud/UnmanagedDependencyCheck.java
@@ -19,13 +19,17 @@
  */
 public class UnmanagedDependencyCheck {
   // Regex of handwritten artifacts.
-  // There are customized artifacts defined in some handwritten libraries, e.g., firestore and
-  // datastore, add entries in regex to exclude these artifacts.
+  // There are customized artifacts defined in gapic-bom and handwritten libraries,
+  // e.g., firestore and datastore, add entries in regex to exclude these artifacts.
   private final static String downstreamArtifact =
       "(com.google.cloud:google-.*)|"
-          + "(com.google.api.grpc:(grpc|proto)-google-.*)|"
+          + "(com.google.api.grpc:(gapic|grpc|proto)-google-.*)|"
           + "(com.google.cloud:proto-google-cloud-firestore-bundle-.*)|"
-          + "(com.google.cloud.datastore:datastore-.*-proto-client)";
+          + "(com.google.cloud.datastore:datastore-.*-proto-client)|"
+          + "(com.google.analytics:google-analytics-.*)|"
+          + "(com.google.apis:google-api-.*)|"
+          + "(com.google.area120:google-area120-.*)|"
+          + "(io.grafeas:grafeas)";
 
   /**
    * @param args An array with two elements.<p> The first string is the path of Java shared

diff --git a/...managed-dependency-check/src/test/java/com/google/cloud/UnmanagedDependencyCheckTest.java b/...managed-dependency-check/src/test/java/com/google/cloud/UnmanagedDependencyCheckTest.java
@@ -20,7 +20,7 @@ public void getUnmanagedDependencyFromSamePomTest()
   }
 
   @Test
-  public void getUnmanagedDependencyFromHWBomTest()
+  public void getUnmanagedDependencyFromGapicAndHandwrittenBomTest()
       throws MavenRepositoryException, InvalidVersionSpecificationException {
     List<String> unManagedDependencies =
         UnmanagedDependencyCheck.getUnmanagedDependencies(

diff --git a/.../unmanaged-dependency-check/src/test/resources/google-internal-artifact-test-case-pom.xml b/.../unmanaged-dependency-check/src/test/resources/google-internal-artifact-test-case-pom.xml
@@ -55,6 +55,13 @@
           <scope>import</scope>
           <type>pom</type>
         </dependency>
+        <dependency>
+          <groupId>com.google.cloud</groupId>
+          <artifactId>gapic-libraries-bom</artifactId>
+          <version>1.23.0</version>
+          <scope>import</scope>
+          <type>pom</type>
+        </dependency>
       </dependencies>
     </dependencyManagement>