add comment to BaseSerializationTest

googleapis · May 10, 2024 · c02f7a2 · c02f7a2
1 parent 905d3c4
commit c02f7a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/java-core/google-cloud-core/src/test/java/com/google/cloud/BaseSerializationTest.java b/java-core/google-cloud-core/src/test/java/com/google/cloud/BaseSerializationTest.java
@@ -34,6 +34,10 @@
  * {@code restorableObjects()} method to return all restorable objects whose state must be tested
  * for proper serialization. Both methods can return {@code null} if no such object needs to be
  * tested.
+ * <p>
+ * This class has not migrated to Junit 5 because downstream libraries, e.g., java-logging,
+ * are extending this class and these libraries still use Junit 4.
+ * Migrating this class to Junit 5 will cause test failures in downstream libraries.
  */
 public abstract class BaseSerializationTest {
 

diff --git a/java-core/pom.xml b/java-core/pom.xml
@@ -37,14 +37,14 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <!-- Test dependencies -->
       <dependency>
         <groupId>org.junit</groupId>
         <artifactId>junit-bom</artifactId>
         <version>5.10.2</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
-      <!-- Test dependencies -->
       <dependency>
         <groupId>com.google.truth</groupId>
         <artifactId>truth</artifactId>