Skip to content

Commit

Permalink
do not specify sample suffix
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeWang1127 committed May 11, 2024
1 parent 2d9cc27 commit 3257cc8
Show file tree
Hide file tree
Showing 8 changed files with 57 additions and 21 deletions.
6 changes: 1 addition & 5 deletions library_generation/generate_library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,7 @@ if [[ "${proto_only}" == "false" ]]; then
mv_src_files "gapic" "test" "${temp_destination_path}"
if [ "${include_samples}" == "true" ]; then
# move java_gapic_srcjar/samples/snippets to samples/snippets
if [[ "${proto_path}" == "grafeas/v1" ]]; then
mv_src_files "samples" "main" "${temp_destination_path}" "io"
else
mv_src_files "samples" "main" "${temp_destination_path}"
fi
mv_src_files "samples" "main" "${temp_destination_path}"
fi
fi
##################### Section 3 #####################
Expand Down
55 changes: 47 additions & 8 deletions library_generation/test/utilities_unit_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,28 +113,67 @@ def test_sh_util_nonexistent_function_fails(self):
with self.assertRaises(RuntimeError):
result = util.sh_util("nonexistent_function")

def test_mv_src_files_gapic_main_succeeds(self):
previous_dir = os.getcwd()
os.chdir(f"{resources_dir}/test_mv_src/gapic")
os.environ["folder_name"] = "example"
util.sh_util("mv_src_files gapic main destination")
self.assertTrue(
os.path.isfile(
"destination/gapic-example/src/main/java/example_main.txt"
)
)
shutil.rmtree("destination/gapic-example")
os.chdir(previous_dir)

def test_mv_src_files_gapic_test_succeeds(self):
previous_dir = os.getcwd()
os.chdir(f"{resources_dir}/test_mv_src/gapic")
os.environ["folder_name"] = "example"
util.sh_util("mv_src_files gapic test destination")
self.assertTrue(
os.path.isfile(
"destination/gapic-example/src/test/java/example_test.txt"
)
)
shutil.rmtree("destination/gapic-example")
os.chdir(previous_dir)

def test_mv_src_files_proto_main_succeeds(self):
previous_dir = os.getcwd()
os.chdir(f"{resources_dir}/test_mv_src/proto")
os.environ["folder_name"] = "example"
util.sh_util("mv_src_files proto main destination")
self.assertTrue(
os.path.isfile(
"destination/proto-example/src/main/java/example_proto_main.txt"
)
)
shutil.rmtree("destination/proto-example")
os.chdir(previous_dir)

def test_mv_src_files_sample_suffix_io_succeeds(self):
previous_dir = os.getcwd()
os.chdir(f"{resources_dir}/test_mv_src")
util.sh_util("mv_src_files samples main destination io")
os.chdir(f"{resources_dir}/test_mv_src/samples")
util.sh_util("mv_src_files samples main destination_io")
self.assertTrue(
os.path.isfile(
"destination/samples/snippets/generated/io/example_io_sample.txt"
"destination_io/samples/snippets/generated/io/example_io_sample.txt"
)
)
shutil.rmtree("destination/samples")
shutil.rmtree("destination_io/samples")
os.chdir(previous_dir)

def test_mv_src_files_sample_suffix_com_succeeds(self):
previous_dir = os.getcwd()
os.chdir(f"{resources_dir}/test_mv_src")
util.sh_util("mv_src_files samples main destination")
os.chdir(f"{resources_dir}/test_mv_src/samples")
util.sh_util("mv_src_files samples main destination_com")
self.assertTrue(
os.path.isfile(
"destination/samples/snippets/generated/com/example_com_sample.txt"
"destination_com/samples/snippets/generated/com/example_com_sample.txt"
)
)
shutil.rmtree("destination/samples")
shutil.rmtree("destination_com/samples")
os.chdir(previous_dir)

def test_eprint_valid_input_succeeds(self):
Expand Down
17 changes: 9 additions & 8 deletions library_generation/utils/utilities.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,26 @@ mv_src_files() {
local category=$1 # one of gapic, proto, samples
local type=$2 # one of main, test
local destination_path=$3
local samples_suffix=$4 # one of com, io (grafeas)
if [ -z "${samples_suffix}" ]; then
samples_suffix="com"
fi
if [ "${category}" == "samples" ]; then
src_suffix="samples/snippets/generated/src/main/java/${samples_suffix}"
src_suffix="samples/snippets/generated/src/main/java"
folder_suffix="samples/snippets/generated"
mkdir -p "${destination_path}/${folder_suffix}"
cp -r "${destination_path}/java_gapic_srcjar/${src_suffix}"/* "${destination_path}/${folder_suffix}"
elif [ "${category}" == "proto" ]; then
src_suffix="${category}/src/${type}/java"
folder_suffix="${category}-${folder_name}/src/${type}"
else
src_suffix="src/${type}"
folder_suffix="${category}-${folder_name}/src"
fi

if [ "${category}" == "samples" ]; then
exit
fi

mkdir -p "${destination_path}/${folder_suffix}"
cp -r "${destination_path}/java_gapic_srcjar/${src_suffix}" "${destination_path}/${folder_suffix}"
if [ "${category}" != "samples" ]; then
rm -r -f "${destination_path}/${folder_suffix}/java/META-INF"
fi
rm -r -f "${destination_path}/${folder_suffix}/java/META-INF"
}

# unzip jar file
Expand Down

0 comments on commit 3257cc8

Please sign in to comment.