ci: test against node 18

googleapis · Sep 9, 2024 · 0a4f648 · 0a4f648
1 parent 1edaea9
commit 0a4f648
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -35,7 +35,7 @@ jobs:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
       - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
         with:
-          node-version: ${{ (endsWith(matrix.package, '-utils') || matrix.package == 'auto-approve' || matrix.package == 'canary-bot' || matrix.package == 'conventional-commit-lint' || matrix.package == 'datastore-lock' || matrix.package == 'object-selector' || matrix.package == 'release-please' || matrix.package == 'secret-rotator' || matrix.package == 'owl-bot' ) && 18 || 14 }}
+          node-version: ${{ (endsWith(matrix.package, '-utils') || matrix.package == 'auto-approve' || matrix.package == 'canary-bot' || matrix.package == 'conventional-commit-lint' || matrix.package == 'datastore-lock' || matrix.package == 'object-selector' || matrix.package == 'release-please' || matrix.package == 'secret-rotator' || matrix.package == 'trusted-contribution' || matrix.package == 'owl-bot' ) && 18 || 14 }}
       - run: echo ./packages/${{ matrix.package }}
       - run: cd ./packages/${{ matrix.package }}
       - run: npm ci

diff --git a/packages/trusted-contribution/package.json b/packages/trusted-contribution/package.json
@@ -22,7 +22,7 @@
     "compile": "tsc -p .",
     "start": "node ./build/src/server.js",
     "pretest": "npm run compile",
-    "test": "cross-env LOG_LEVEL=fatal c8 mocha build/test",
+    "test": "cross-env LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch build/test",
     "fix": "gts fix",
     "lint": "gts check"
   },
@@ -49,6 +49,6 @@
     "typescript": "~4.9.0"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 18"
   }
 }