Handle false for the case when json_encode returns false

googleapis · Oct 8, 2024 · fb0ac53 · fb0ac53
1 parent 8699369
commit fb0ac53
Showing 1 changed file with 28 additions and 3 deletions.
diff --git a/src/Logging/LoggingTrait.php b/src/Logging/LoggingTrait.php
@@ -44,9 +44,17 @@ private function logRequest(LogEvent $event): void
             'retryAttempt' => $event->retryAttempt
         ];
 
+        // Remove null values
         $debugEvent['jsonPayload'] = array_filter($jsonPayload, fn ($value) => !is_null($value));
 
-        $this->logger->debug((string) json_encode($debugEvent));
+        $stringifiedEvent = json_encode($debugEvent);
+
+        // There was an error stringifying the event, return to not break execution
+        if ($stringifiedEvent === false) {
+            return;
+        }
+
+        $this->logger->debug($stringifiedEvent);
     }
 
     /**
@@ -66,12 +74,21 @@ private function logResponse(LogEvent $event): void
             ]
         ];
 
+        // Remove null values
         $debugEvent = array_filter($debugEvent, fn ($value) => !is_null($value));
         $debugEvent['jsonPayload'] = array_filter(
             $debugEvent['jsonPayload'],
             fn ($value) => !is_null($value)
         );
-        $this->logger->debug((string) json_encode($debugEvent));
+
+        $stringifiedEvent = json_encode($debugEvent);
+
+        // There was an error stringifying the event, return to not break execution
+        if ($stringifiedEvent === false) {
+            return;
+        }
+
+        $this->logger->debug($stringifiedEvent);
 
         if ($event->status) {
             $infoEvent = [
@@ -84,9 +101,17 @@ private function logResponse(LogEvent $event): void
                 ]
             ];
 
+            // Remove null values
             $infoEvent = array_filter($infoEvent, fn ($value) => !is_null($value));
 
-            $this->logger->info((string) json_encode($infoEvent));
+            $stringifiedEvent = json_encode($debugEvent);
+
+            // There was an error stringifying the event, return to not break execution
+            if ($stringifiedEvent === false) {
+                return;
+            }
+
+            $this->logger->info($stringifiedEvent);
         }
     }