Skip to content

Commit

Permalink
Merge branch 'main' into user-refresh-id-tokens
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer authored Oct 4, 2024
2 parents cbcc986 + dd5f6ef commit 25cf264
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 14 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Lint
on:
push:
branches: [ main ]
pull_request:

permissions:
contents: read
jobs:
style:
name: PHP Style Check
uses: GoogleCloudPlatform/php-tools/.github/workflows/code-standards.yml@main

staticanalysis:
name: PHPStan Static Analysis
uses: GoogleCloudPlatform/php-tools/.github/workflows/static-analysis.yml@main
with:
autoload-file: tests/phpstan-autoload.php
14 changes: 2 additions & 12 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
test:
strategy:
matrix:
php: [ "8.0", "8.1", "8.2", "8.3" ]
php: [ "8.1", "8.2", "8.3" ]
os: [ ubuntu-latest ]
include:
- os: windows-latest
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.0"
php-version: "8.1"
- name: Install Dependencies
uses: nick-invision/retry@v3
with:
Expand All @@ -49,13 +49,3 @@ jobs:
command: composer update --prefer-lowest
- name: Run Script
run: vendor/bin/phpunit

style:
name: PHP Style Check
uses: GoogleCloudPlatform/php-tools/.github/workflows/code-standards.yml@main

staticanalysis:
name: PHPStan Static Analysis
uses: GoogleCloudPlatform/php-tools/.github/workflows/static-analysis.yml@main
with:
autoload-file: tests/phpstan-autoload.php
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"docs": "https://googleapis.github.io/google-auth-library-php/main/"
},
"require": {
"php": "^8.0",
"php": "^8.1",
"firebase/php-jwt": "^6.0",
"guzzlehttp/guzzle": "^7.4.5",
"guzzlehttp/psr7": "^2.4.5",
Expand Down
2 changes: 1 addition & 1 deletion tests/ApplicationDefaultCredentialsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ public function testImpersonatedServiceAccountCredentials()
null,
'a default scope'
);

$this->assertInstanceOf(ImpersonatedServiceAccountCredentials::class, $creds);

$this->assertEquals('[email protected]', $creds->getClientName());

$sourceCredentialsProperty = (new ReflectionClass($creds))->getProperty('sourceCredentials');
Expand Down

0 comments on commit 25cf264

Please sign in to comment.