-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use the new SBOM generator tool. #743
Conversation
@jskeet this one slipped through? |
Whoops, thanks. |
.kokoro/release.sh
Outdated
@@ -36,4 +38,8 @@ export NUGET_API_KEY="$(cat "$SECRETS_LOCATION"/google-apis-nuget-api-key)" | |||
|
|||
# Push the changes to nuget. | |||
cd ./releasebuild/nuget | |||
for pkg in *.nupkg; do dotnet nuget push -s https://api.nuget.org/v3/index.json -k $NUGET_API_KEY $pkg; done | |||
|
|||
for pkg in *.nupkg; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally put the "do" on the next line, but hey :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :), I'll merge on green!
.kokoro/release.sh
Outdated
@@ -36,4 +38,9 @@ export NUGET_API_KEY="$(cat "$SECRETS_LOCATION"/google-apis-nuget-api-key)" | |||
|
|||
# Push the changes to nuget. | |||
cd ./releasebuild/nuget | |||
for pkg in *.nupkg; do dotnet nuget push -s https://api.nuget.org/v3/index.json -k $NUGET_API_KEY $pkg; done | |||
|
|||
for pkg in *.nupkg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the ;
from the end of the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yikes, done now as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "request changes" so it doesn't get merged without the fix
No description provided.