fix: remove content_sent from StreamingSequences #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run |
noahdietz
reviewed
Jul 7, 2023
updated description |
noahdietz
approved these changes
Jul 7, 2023
noahdietz
changed the title
noahdietz
changed the title
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.28.3](https://togithub.com/googleapis/gapic-showcase/compare/v0.28.2...v0.28.3) (2023-07-07) ### Bug Fixes * Remove content_sent from StreamingSequences ([#1351](https://togithub.com/googleapis/gapic-showcase/issues/1351)) ([ae910cc](https://togithub.com/googleapis/gapic-showcase/commit/ae910cca182787fb5babbfe1005b086d4f2f8c4b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, server streaming APIs do not resume from the point of failure. Before removing the contentSent property, the server would keep track of the last content that was sent before failing. To get closure to how server streams currently react to failure, we removed the contentSent property. This means that when we retry the request, the server will send the entire content, rather than starting from where it left off.