feat: Add ability to echo request headers in response

googleapis · Apr 15, 2024 · f15a0bb · f15a0bb
1 parent add2dc2
commit f15a0bb
Show file tree

Hide file tree

Showing 11 changed files with 463 additions and 332 deletions.
diff --git a/cmd/gapic-showcase/echo.go b/cmd/gapic-showcase/echo.go
@@ -59,6 +59,8 @@ func init() {
 
 	EchoCmd.Flags().StringVar(&echoInputOtherRequestId, "other_request_id", "", "To facilitate testing of...")
 
+	EchoCmd.Flags().StringSliceVar(&EchoInput.HttpRequestHeaderToEcho, "http_request_header_to_echo", []string{}, "Echo http request header as trailing metadata")
+
 	EchoCmd.Flags().StringVar(&EchoInputResponse, "response", "", "Choices: content, error")
 
 	EchoCmd.Flags().StringVar(&EchoFromFile, "from_file", "", "Absolute path to JSON file containing request payload")

diff --git a/schema/google/showcase/v1beta1/echo.proto b/schema/google/showcase/v1beta1/echo.proto
@@ -222,6 +222,9 @@ message EchoRequest {
   optional string other_request_id = 8 [
     (google.api.field_info).format = UUID4
   ];
+
+  // Echo http request header as trailing metadata
+  repeated string http_request_header_to_echo = 9;
 }
 
 // The response message for the Echo methods.
@@ -237,6 +240,13 @@ message EchoResponse {
 
   // The other request ID specified or autopopulated in the request.
   string other_request_id = 4;
+
+
+  message RepeatedValues {
+    repeated string header_values = 1;
+  }
+  // The HTTP header to echo as specified in the request
+  map<string, RepeatedValues> http_request_header_value = 5;
 }
 
 // The request message used for the EchoErrorDetails method.

diff --git a/schema/googleapis b/schema/googleapis
diff --git a/server/genproto/compliance.pb.go b/server/genproto/compliance.pb.go
diff --git a/server/genproto/echo.pb.go b/server/genproto/echo.pb.go
diff --git a/server/genproto/identity.pb.go b/server/genproto/identity.pb.go
diff --git a/server/genproto/messaging.pb.go b/server/genproto/messaging.pb.go
diff --git a/server/genproto/sequence.pb.go b/server/genproto/sequence.pb.go
diff --git a/server/genproto/testing.pb.go b/server/genproto/testing.pb.go
diff --git a/server/services/echo_service.go b/server/services/echo_service.go
@@ -18,6 +18,7 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"slices"
 	"strconv"
 	"strings"
 	"time"
@@ -46,12 +47,21 @@ type echoServerImpl struct {
 
 func (s *echoServerImpl) Echo(ctx context.Context, in *pb.EchoRequest) (*pb.EchoResponse, error) {
 	err := status.ErrorProto(in.GetError())
-	if err != nil {
+	md, ok := metadata.FromIncomingContext(ctx)
+	if err != nil || !ok {
 		return nil, err
 	}
 	echoHeaders(ctx)
 	echoTrailers(ctx)
-	return &pb.EchoResponse{Content: in.GetContent(), Severity: in.GetSeverity(), RequestId: in.GetRequestId(), OtherRequestId: in.GetOtherRequestId()}, nil
+	request_headers := make(map[string]*pb.EchoResponse_RepeatedValues)
+	headers_to_track := in.GetHttpRequestHeaderToEcho()
+	for k, v := range md {
+		if slices.Contains(headers_to_track, k) {
+			request_headers[k] = &pb.EchoResponse_RepeatedValues{HeaderValues: v}
+		}
+	}
+
+	return &pb.EchoResponse{Content: in.GetContent(), Severity: in.GetSeverity(), RequestId: in.GetRequestId(), OtherRequestId: in.GetOtherRequestId(), HttpRequestHeaderValue: request_headers}, nil
 }
 
 func (s *echoServerImpl) EchoErrorDetails(ctx context.Context, in *pb.EchoErrorDetailsRequest) (*pb.EchoErrorDetailsResponse, error) {

diff --git a/server/services/echo_service_test.go b/server/services/echo_service_test.go
@@ -42,12 +42,16 @@ func TestEcho_success(t *testing.T) {
 	server := NewEchoServer()
 	for _, val := range table {
 		in := &pb.EchoRequest{
-			Response: &pb.EchoRequest_Content{Content: val},
-			Severity: pb.Severity_CRITICAL,
+			Response:                &pb.EchoRequest_Content{Content: val},
+			Severity:                pb.Severity_CRITICAL,
+			HttpRequestHeaderToEcho: []string{"x-goog-api-version"},
 		}
 		mockStream := &mockUnaryStream{t: t}
 		ctx := appendTestOutgoingMetadata(context.Background(), &mockSTS{t: t, stream: mockStream})
 		out, err := server.Echo(ctx, in)
+		if !reflect.DeepEqual(out.HttpRequestHeaderValue["x-goog-api-version"].HeaderValues[0], "apiVersion") {
+			t.Errorf("Did not find apiVersion in response")
+		}
 		if err != nil {
 			t.Error(err)
 		}
@@ -153,6 +157,7 @@ func (m *mockExpandStream) SetTrailer(md metadata.MD) {
 
 func (m *mockExpandStream) SetHeader(md metadata.MD) error {
 	m.head = append(m.head, md.Get("x-goog-request-params")...)
+	m.head = append(m.head, md.Get("x-goog-api-version")...)
 	return nil
 }
 
@@ -898,6 +903,6 @@ func TestBlockError(t *testing.T) {
 
 func appendTestOutgoingMetadata(ctx context.Context, stream grpc.ServerTransportStream) context.Context {
 	ctx = grpc.NewContextWithServerTransportStream(ctx, stream)
-	ctx = metadata.NewIncomingContext(ctx, metadata.Pairs("showcase-trailer", "show", "showcase-trailer", "case", "trailer", "trail", "x-goog-request-params", "showcaseHeader", "x-goog-request-params", "anotherHeader", "header", "head"))
+	ctx = metadata.NewIncomingContext(ctx, metadata.Pairs("showcase-trailer", "show", "showcase-trailer", "case", "trailer", "trail", "x-goog-request-params", "showcaseHeader", "x-goog-request-params", "anotherHeader", "header", "head", "x-goog-api-version", "apiVersion"))
 	return ctx
 }