address review feedback

googleapis · Apr 15, 2024 · 5115173 · 5115173
1 parent 200897b
commit 5115173
Show file tree

Hide file tree

Showing 5 changed files with 280 additions and 304 deletions.
diff --git a/cmd/gapic-showcase/echo.go b/cmd/gapic-showcase/echo.go
@@ -59,8 +59,6 @@ func init() {
 
 	EchoCmd.Flags().StringVar(&echoInputOtherRequestId, "other_request_id", "", "To facilitate testing of...")
 
-	EchoCmd.Flags().StringSliceVar(&EchoInput.HttpRequestHeaderToEcho, "http_request_header_to_echo", []string{}, "Http request headers to echo via...")
-
 	EchoCmd.Flags().StringVar(&EchoInputResponse, "response", "", "Choices: content, error")
 
 	EchoCmd.Flags().StringVar(&EchoFromFile, "from_file", "", "Absolute path to JSON file containing request payload")

diff --git a/schema/google/showcase/v1beta1/echo.proto b/schema/google/showcase/v1beta1/echo.proto
@@ -222,9 +222,6 @@ message EchoRequest {
   optional string other_request_id = 8 [
     (google.api.field_info).format = UUID4
   ];
-
-  // Http request headers to echo via EchoResponse.http_request_header_value
-  repeated string http_request_header_to_echo = 9;
 }
 
 // The response message for the Echo methods.