Skip to content

Commit

Permalink
add campaign_asset to path lookup util (#328)
Browse files Browse the repository at this point in the history
Co-authored-by: Fei Xiang <[email protected]>
  • Loading branch information
xflesym and xflesym authored Jun 29, 2021
1 parent baefbda commit ca1e27e
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
12.0.2:
- Fixed a missing type in path lookup util.

12.0.1:
- Fixed an issue in the gem factories files.

Expand Down
1 change: 1 addition & 0 deletions lib/google/ads/google_ads/utils/path_lookup_config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ module PathLookupConfig
bidding_strategy: [:customer, [:bidding_strategy]],
bidding_strategy_simulation: [:customer, :bidding_strategy, :type, :modification_method, :start_date, :end_date],
billing_setup: [:customer, [:billing]],
campaign_asset: [:customer, [:campaign, :asset, :field_type]],
campaign_audience_view: [:customer, [:campaign, :criterion]],
campaign_bid_modifier: [:customer, [:campaign, :criterion]],
campaign_budget: [:customer, [:campaign_budget]],
Expand Down
2 changes: 1 addition & 1 deletion lib/google/ads/google_ads/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
module Google
module Ads
module GoogleAds
CLIENT_LIB_VERSION = '12.0.1'.freeze
CLIENT_LIB_VERSION = '12.0.2'.freeze
VERSION = CLIENT_LIB_VERSION
end
end
Expand Down
12 changes: 12 additions & 0 deletions test/test_path_lookup_util.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ def test_path_generation_v5()
expected = 'customers/1234/billingSetups/5678'
assert_equal(expected, util.billing_setup(1234, 5678))

expected = 'customers/1234/campaignAssets/56~78~90'
assert_equal(expected, util.campaign_asset(1234, 56, 78, 90))

expected = 'customers/1234/campaignAudienceViews/567~890'
assert_equal(expected, util.campaign_audience_view(1234, 567, 890))

Expand Down Expand Up @@ -389,6 +392,9 @@ def test_path_generation_v6()
expected = 'customers/1234/billingSetups/5678'
assert_equal(expected, util.billing_setup(1234, 5678))

expected = 'customers/1234/campaignAssets/56~78~90'
assert_equal(expected, util.campaign_asset(1234, 56, 78, 90))

expected = 'customers/1234/campaignAudienceViews/567~890'
assert_equal(expected, util.campaign_audience_view(1234, 567, 890))

Expand Down Expand Up @@ -707,6 +713,9 @@ def test_path_generation_v7()
expected = 'customers/1234/billingSetups/5678'
assert_equal(expected, util.billing_setup(1234, 5678))

expected = 'customers/1234/campaignAssets/56~78~90'
assert_equal(expected, util.campaign_asset(1234, 56, 78, 90))

expected = 'customers/1234/campaignAudienceViews/567~890'
assert_equal(expected, util.campaign_audience_view(1234, 567, 890))

Expand Down Expand Up @@ -1046,6 +1055,9 @@ def test_path_generation_v8()
expected = 'customers/1234/billingSetups/5678'
assert_equal(expected, util.billing_setup(1234, 5678))

expected = 'customers/1234/campaignAssets/56~78~90'
assert_equal(expected, util.campaign_asset(1234, 56, 78, 90))

expected = 'customers/1234/campaignAudienceViews/567~890'
assert_equal(expected, util.campaign_audience_view(1234, 567, 890))

Expand Down

0 comments on commit ca1e27e

Please sign in to comment.