-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OSX, resolve #22 #37
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this functionality!
@@ -89,6 +89,13 @@ function! s:InformUserAboutCopiedText(first, last) | |||
endif | |||
endfunction | |||
|
|||
" wait to remove file | |||
function! s:WaitToRemoveFile(file) | |||
sleep 1000m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this adds a 1-second delay, which wasn't here before. Is this really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me, without a delay, safari will not able to read the file before it has been deleted. (I use vim 8 btw)
I was considered to add a new variable to this plugin. maybe open_browser_delay
, defaults to false
?
how do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new plugin variable sounds good. You could also make it a floating point variable -- say, open_browser_delay_seconds
-- and default it to 0.0
. Be sure to add documentation in flags.vim
in the same way that the others are documented. It would be great if you could also re-run vimdoc
to update the online help.
@@ -89,6 +89,13 @@ function! s:InformUserAboutCopiedText(first, last) | |||
endif | |||
endfunction | |||
|
|||
" wait to remove file | |||
function! s:WaitToRemoveFile(file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really need the delay, how about s:RemoveFileAfterDelay(file, delay)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will do
Hi, I just made a patch for osx, please check and let me know if anything else required, thanks.