CJS: Module exports should be enumerable #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We created the properties on the module object as non enumerable. This change makes them enumerable which is consistent with ES6 module instance objects. Fixes google#2118
|
@johnjbarton PTAL |
|
The tests check that the code generated is what we expect to be generated, but they don't seem to exactly check that the bug was fixed. LGTM |
|
There is a feature test for this. When #1979 is done CJS will run almost all of the feature tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We created the properties on the module object as non enumerable.
This change makes them enumerable which is consistent with ES6 module
instance objects.
Fixes #2118