Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: report start-of-token pos for parsePrimary errors #533

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

adonovan
Copy link
Collaborator

@adonovan adonovan commented Mar 28, 2024

syntax: report start-of-token pos for parsePrimary errors

(Conceivably other places need a similar ttreament, but they all seemed benign or marginal.)

Fixes #532

@adonovan adonovan requested a review from jayconrod March 28, 2024 18:36
(Conceivably other places need a similar treament, but they
all seemed benign or marginal.)

Fixes #352
Copy link
Collaborator

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR description should say this fixes #532 rather than #352.

@adonovan
Copy link
Collaborator Author

LGTM. PR description should say this fixes #532 rather than #352.

Well spotted. Thanks!

@adonovan adonovan merged commit e6e8e7c into master Mar 29, 2024
27 checks passed
@adonovan adonovan deleted the fix-newline branch March 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: unexpected NEWLINE token is reported on following line
2 participants