Use pdl-compiler directly #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May not be needed after google/pdl#61. |
marshallpierce
force-pushed
the
mp/pdlc-as-library
branch
from
6ba7380
to
8c8b45c
Compare
marshallpierce
commented
Feb 26, 2024
| - name: Install dependencies | ||
| run: | | ||
| cargo install pdl-compiler --version 0.2.2 | ||
| cargo install pdl-compiler --version 0.2.3 |
There was a problem hiding this comment.
I'm assuming it's desirable for pdl-compiler to be up to date -- if you'd rather stick with 0.2.2 that's fine too of course
|
|
||
| // Find the pdl tool. Expecting it at CARGO_HOME/bin | ||
| let pdl = match env::var("CARGO_HOME") { | ||
| let pdlc = match env::var("CARGO_HOME") { |
There was a problem hiding this comment.
Is it even desirable to maintain this code path? If someone is using Cargo vs the Blaze build, when would they want to use the external pdlc? Or perhaps should it be present to allow hypothetical debugging of issues specific to a pdlc binary, but only used if an env var is set?
marshallpierce
commented
Feb 26, 2024
| @@ -26,9 +26,13 @@ jobs: | |||
| with: | |||
| submodules: recursive | |||
|
|
|||
| - name: Check Cargo build | |||
| run: | | |||
| cargo test | |||
There was a problem hiding this comment.
might as well check that the cargo build works 🤷
If the `pdlc` binary is not available, use `pdl_compiler` as a library instead. Also do some misc tidying of the build script, since it looks like the output path was being derived in different ways with the same result.
marshallpierce
force-pushed
the
mp/pdlc-as-library
branch
from
8c8b45c
to
4556d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
pdlcbinary is not available, usepdl_compileras a library instead.Also do some misc tidying of the build script, since it looks like the output path was being derived in different ways with the same result.