test: update case to reflect recent config parsing changes #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
+ Coverage 68.31% 68.38% +0.07%
==========================================
Files 175 175
Lines 16764 16784 +20
==========================================
+ Hits 11452 11478 +26
+ Misses 4680 4676 -4
+ Partials 632 630 -2 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaviour changed as a result of both #1252 (which makes
LoadPathno longer a recognized config key) and #1249 (which causes the scanner to error when a config has an unknown key), but they didn't directly conflict with each other so got landed onmainwithout this being picked up(fwiw I'm not worried about this being a reoccurring thing that's worth guarding or preventing somehow as its usually pretty rare 🤷)