-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle parsing versions in composer.lock
files that are numbers rather than strings
#1139
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 68.75% 68.77% +0.01%
==========================================
Files 184 184
Lines 17714 17733 +19
==========================================
+ Hits 12180 12196 +16
- Misses 4875 4877 +2
- Partials 659 660 +1 ☔ View full report in Codecov by Sentry. |
I think we should try to figure out why this is generated first before merging this fix. I'm not sure if we can confidently support this before figuring out the root cause. (e.g. will the number ever have a decimal point in it?) |
It seems |
b329a85
to
1691bef
Compare
72e5b3f
to
6b54848
Compare
It seems it's technically possible for
composer.lock
files to have a number forversion
in packages - I can't actually reproduce this withcomposer
itself, but if I manually edit a lockfile to have a number instead of a string it doesn't complain or change the value.It would be good to understand more about how this could happen in the wild, but it's easy enough to support either way.
Resolves #1138