test(rpmdb): add some test scenario for rpmdb parser

google · Mar 6, 2023 · 436475b · 436475b
1 parent 20b5e0f
commit 436475b
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/pkg/lockfile/fixtures/rpm/not-an-rpmdb b/pkg/lockfile/fixtures/rpm/not-an-rpmdb
@@ -0,0 +1 @@
+# Clearly not an rpmdb file!
diff --git a/pkg/lockfile/rpmdb.go b/pkg/lockfile/rpmdb.go
@@ -36,13 +36,12 @@ func ParseRpmDB(pathToLockfile string) ([]PackageDetails, error) {
 			continue
 		}
 
-		var pkg = PackageDetails{
+		packages = append(packages, PackageDetails{
+			Name:      rpmPkg.Name,
+			Version:   rpmPkg.Version,
 			Ecosystem: RedHatEcosystem,
 			CompareAs: RedHatEcosystem,
-		}
-		pkg.Name = rpmPkg.Name
-		pkg.Version = rpmPkg.Version
-		packages = append(packages, pkg)
+		})
 	}
 
 	return packages, nil

diff --git a/pkg/lockfile/rpmdb_test.go b/pkg/lockfile/rpmdb_test.go
@@ -6,8 +6,26 @@ import (
 	"github.com/google/osv-scanner/pkg/lockfile"
 )
 
+func TestParseRpmDB_SQLite_FileDoesNotExist(t *testing.T) {
+	t.Parallel()
+
+	packages, err := lockfile.ParseRpmDB("fixtures/rpm/does-not-exist")
+
+	expectErrContaining(t, err, "could not open")
+	expectPackages(t, packages, []lockfile.PackageDetails{})
+}
+
+func TestParseRpmDB_SQLite_NotAnRpmDb(t *testing.T) {
+	t.Parallel()
+
+	packages, err := lockfile.ParseRpmDB("fixtures/rpm/not-an-rpmdb")
+
+	expectErrContaining(t, err, "could not open")
+	expectPackages(t, packages, []lockfile.PackageDetails{})
+}
+
 // Berkeley DB (rpm < v4.16)
-func TestRpmDb_BDB_Single(t *testing.T) {
+func TestParseRpmDB_BDB_Single(t *testing.T) {
 	t.Parallel()
 
 	packages, err := lockfile.ParseRpmDB("fixtures/rpm/Packages")
@@ -26,7 +44,7 @@ func TestRpmDb_BDB_Single(t *testing.T) {
 	})
 }
 
-func TestRpmDb_SQLite_Single(t *testing.T) {
+func TestParseRpmDB_SQLite_Single(t *testing.T) {
 	t.Parallel()
 
 	packages, err := lockfile.ParseRpmDB("fixtures/rpm/rpmdb.sqlite")