Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base builder exception. #12623

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix base builder exception. #12623

merged 1 commit into from
Oct 21, 2024

Conversation

oliverchang
Copy link
Collaborator

No description provided.

@oliverchang oliverchang merged commit 4b20cd8 into master Oct 21, 2024
15 of 18 checks passed
@oliverchang oliverchang deleted the fix-base-build branch October 21, 2024 04:00
DonggeLiu
DonggeLiu reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu left review comments

@jonathanmetzman jonathanmetzman Awaiting requested review from jonathanmetzman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverchang @DonggeLiu