Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build failure for aptos-core #11027

Merged
merged 4 commits into from
Nov 13, 2023
Merged

fix build failure for aptos-core #11027

merged 4 commits into from
Nov 13, 2023

Conversation

gedigi
Copy link
Contributor

@gedigi gedigi commented Sep 27, 2023

This PR asets the rust nightly version to generic to solve a build issue.

@github-actions
Copy link

gedigi is either the primary contact or is in the CCs list of projects/aptos-core.
gedigi has previously contributed to projects/aptos-core. The previous PR was #10904

@jonathanmetzman
Copy link
Contributor

I think the failure is spurious right?

@gedigi
Copy link
Contributor Author

gedigi commented Sep 27, 2023

I think the failure is spurious right?

Yes

@jonathanmetzman
Copy link
Contributor

I think this won't work. Let me figure out an alternative.

@gedigi
Copy link
Contributor Author

gedigi commented Oct 6, 2023

@jonathanmetzman we are changing approach a bit and this account is not going to be used - at least for now. however, this PR contains a fix for an existing build failure, so it would be awesome if you could merge it. thanks!

--
@jonathanmetzman can this be approved please? we've been dealing with a build failure: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62877

@gedigi gedigi changed the title add service account to aptos-core fix build failure for aptos-core Oct 6, 2023
@gedigi
Copy link
Contributor Author

gedigi commented Nov 6, 2023

gentle reminder. this PR is waiting to be merged for several weeks. how can we get it approved? thank you.

@jonathanmetzman jonathanmetzman merged commit 3e0e29f into google:master Nov 13, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants