Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helper.py builds on ARM macs #10967

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix helper.py builds on ARM macs #10967

wants to merge 2 commits into from

Conversation

jonathanmetzman
Copy link
Contributor

No description provided.

@jonathanmetzman
Copy link
Contributor Author

Can someone with an ARM mac test that this command works:
python infra/helper.py build_fuzzers --architecture aarch64

@jonathanmetzman jonathanmetzman changed the title Fix builds on ARM macs Fix helper.py builds on ARM macs Sep 14, 2023
@szhorvat
Copy link
Contributor

Yes, it does. Thanks for the fix!

@jonathanmetzman
Copy link
Contributor Author

/gcbrun skip

@jonathanmetzman
Copy link
Contributor Author

jonathanmetzman commented Sep 15, 2023

There's a bit of a remaining problem. The ARM versions of the base-images are basically never updated. I need to figure out how to update them again so they are at least recent, but there's no process for keeping them up to date yet.

@szhorvat
Copy link
Contributor

szhorvat commented May 5, 2024

Would be nice to complete and merge this fix :-)

@guidovranken
Copy link
Contributor

Can you please merge this @jonathanmetzman ? I kinda need it. Thanks.

@jonathanmetzman
Copy link
Contributor Author

I'm not sure it is a good idea. We never update the base-builder for ARM so encouraging people to use it will probably encourage using a footgun. I think I'd rather it didn't work.

@jkylekelly
Copy link

I'm not sure it is a good idea. We never update the base-builder for ARM so encouraging people to use it will probably encourage using a footgun. I think I'd rather it didn't work.

It'd be nice if this were noted somewhere more evident so that future users (myself included) don't waste too much time trying to get this working 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants