Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support i386 in Lua #10856

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Support i386 in Lua #10856

merged 3 commits into from
Aug 18, 2023

Conversation

ligurio
Copy link
Contributor

@ligurio ligurio commented Aug 18, 2023

  • lua: support i386 architecture
  • lua: fix compiler warning
  • lua: fix homepage url

@github-actions
Copy link

ligurio is either the primary contact or is in the CCs list of projects/lua.
ligurio has previously contributed to projects/lua. The previous PR was #10732

fuzz_lua.c:150:36: warning: passing 'const uint8_t *' (aka 'const unsigned char *') to parameter of type 'const char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
    dochunk(L, luaL_loadbufferx(L, data, size, "test", "t"));
                                   ^~~~
./lauxlib.h:97:62: note: passing argument to parameter 'buff' here
LUALIB_API int (luaL_loadbufferx) (lua_State *L, const char *buff, size_t sz,
                                                             ^
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman
Copy link
Contributor

Are you a maintainer of this project by the way?

@ligurio
Copy link
Contributor Author

ligurio commented Aug 18, 2023

Are you a maintainer of this project by the way?

Seems so. I'm quite interested in testing Lua runtimes (PUC Rio Lua, LuaJIT).
I am building a testsuite [1] that is suitable for all Lua runtimes because of common Lua C API and I'm interested in running these tests in OSS Fuzz.

  1. https://github.com/ligurio/lua-c-api-tests

@ligurio
Copy link
Contributor Author

ligurio commented Aug 18, 2023

BTW, when aarch64 arch will be available for everyone on OSS Fuzz?

@jonathanmetzman jonathanmetzman merged commit 0abb82b into google:master Aug 18, 2023
15 checks passed
@jonathanmetzman
Copy link
Contributor

BTW, when aarch64 arch will be available for everyone on OSS Fuzz?

This is not an official estimate but I'd guess around this winter. I'm doing a big refactor of ClusterFuzz that should make it doable. We don't have a solution for build infra though (GCB only supports intel).

@ligurio ligurio deleted the ligurio/support-i386-lua branch August 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants