Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aptos-core Dockerfile + build.sh #10757

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

gedigi
Copy link
Contributor

@gedigi gedigi commented Jul 28, 2023

Add Dockerfile and build.sh for aptos-core

@google-cla
Copy link

google-cla bot commented Jul 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

gedigi has previously contributed to projects/aptos-core. The previous PR was #10487

@jonathanmetzman
Copy link
Contributor

The CI error looks like it is specific to CI and won't reoccur in production (it looks like an OOM and we have more memory to build in prod). Can you confirm this builds and I'll merge.

@gedigi
Copy link
Contributor Author

gedigi commented Jul 31, 2023

The CI error looks like it is specific to CI and won't reoccur in production (it looks like an OOM and we have more memory to build in prod). Can you confirm this builds and I'll merge.

This passes successfully on my system:

$ time (
  PROJECT_NAME=aptos-core
  python3 infra/helper.py build_image $PROJECT_NAME
  python3 infra/helper.py build_fuzzers $PROJECT_NAME
  python3 infra/helper.py build_fuzzers --sanitizer coverage $PROJECT_NAME
  python3 infra/helper.py check_build $PROJECT_NAME
 )
[...]
real    38m59.082s
user    0m0.882s
sys     0m0.833s

@jonathanmetzman is this acceptable?

@jonathanmetzman
Copy link
Contributor

Oof,the last delay was not intentional, my bad

@jonathanmetzman jonathanmetzman merged commit 3826059 into google:master Aug 21, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants