-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: add vscode extension poc #10592
Conversation
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! we'll also want some user documentation at some point.
|
||
let targetProject = 'N/A'; | ||
let targetFuzzer = 'N/A'; | ||
// Logic for passing the file. This is based off of clusterfuzz monorail reports, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where exactly is this file coming from? Can we make this a more machine readable format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes from the Monorail bug page, e.g.: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59747
The problem with making it machine readable is the user needs to access the URL and authenticate to get the details. At that point it's easy to copy paste.
That said, I think this functionality has a lot of potential to improve but requires the ability to get details about issues in a headless mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. How is that extracted in the first place? That bit wasn't clear :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy the parts of the monorail report and place it in a .info
file. I added documentation around the feature which should clarify things. Let me know if it helps!
we'll also want some user documentation at some point.
I agree on this, which will ultimately document these things more verbosely. But I prefer to do this in follow up PRs.
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Is this ready for merge @oliverchang ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need the conflict resolved.
Add initial layout or a vscode extension.
Several commands included in the extension, including commands for
Many ideas can be put into the vscode extension, for example:
helper.py
with some form of command called "check_progress` which will run a small build pipeline + coverage and check if the coverage performs better than what is currently achieved. I think there's more to explore in this space.