fix(state_share): new method to include credentials for state sharing #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to chrome introducing restrictions on setting protocols using the URL API
jbms
reviewed
Nov 6, 2023
| @@ -73,8 +73,9 @@ export class StateShare extends RefCounted { // call it a widget? no because it | |||
| }, responseJson) | |||
| .then((res) => { | |||
| const stateUrl = new URL(res); | |||
| stateUrl.protocol = protocol; // copy protocol in case it contains authentication type | |||
| const link = `${window.location.origin}/#!${stateUrl}`; | |||
| const stateUrlWithoutProtocol = stateUrl.toString().split(stateUrl.protocol)[1]; | |||
There was a problem hiding this comment.
Split is kind of an odd way to handle this -- instead could just use substring(stateUrl.protocol.length)
There was a problem hiding this comment.
Yes, made this change
chrisj
force-pushed
the
cj_state_share_chrome_fix
branch
from
ba6aaed
to
950a744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to chrome introducing restrictions on setting protocols using the URL API
The second line is silently rejected in chrome 118.