feat: change image user layer UI labels #496
Conversation
To try and make it clearer that they don't impact volume rendering Also that the 3D resolution does not change the data resolution
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
src/neuroglancer/image_user_layer.ts
Outdated
| { | ||
| label: 'Volume rendering (experimental)', | ||
| toolJson: VOLUME_RENDERING_JSON_KEY, | ||
| ...checkboxLayerControl(layer => layer.volumeRendering), | ||
| }, | ||
| { | ||
| label: 'Resolution (3d)', | ||
| label: 'Resolution indicator (3D)', |
There was a problem hiding this comment.
Per the comment in the other PR, the change to this label may be unnecessary if it is changed to control the number of samples.
python/neuroglancer/viewer_state.py
Outdated
| @export_tool | ||
| class VolumeRenderingTool(Tool): | ||
| __slots__ = () | ||
| TOOL_TYPE = "volumeRendering" |
There was a problem hiding this comment.
Per the comment in the other PR, I think there could be one option that controls the volume rendering mode, with one mode being "off" --- then there wouldn't be a separate tool and python option.
There was a problem hiding this comment.
Agreed, I'll change the other PR to have this new mode controllable from Python and remove the new tool from this PR
seankmartin
changed the title
Goal
To try and make it clearer that opacity and blending don't impact volume rendering, only the cross-section slice view