Retain identityRef retrieved from file

Currently the identity has a chance to be released before it's added to an NSURLCredential.
google · Apr 26, 2017 · 08e4331 · 08e4331
1 parent 8ead0aa
commit 08e4331
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Source/MOLAuthenticatingURLSession.m b/Source/MOLAuthenticatingURLSession.m
@@ -403,8 +403,11 @@ - (SecIdentityRef)identityFromFile:(NSString *)file password:(NSString *)passwor
     [self log:@"Client Trust: Couldn't load client certificate %@: %d", self.clientCertFile, err];
     return nil;
   }
+
+  CFDictionaryRef firstDict = [identities firstObject];
+  SecIdentityRef firstRef = (__bridge SecIdentityRef)firstDict[(__bridge id)kSecImportItemIdentity];
 
-  return (__bridge SecIdentityRef)[identities firstObject][(__bridge id)kSecImportItemIdentity];
+  return (firstRef != NULL) ? CFRetain(firstRef) : NULL;
 }
 
 - (void)log:(NSString *)format, ... {