Skip to content

Commit

Permalink
Add a <developers> section to the main pom.xml.
Browse files Browse the repository at this point in the history
  • Loading branch information
@eamonnmcmanus
eamonnmcmanus committed Oct 25, 2022
1 parent 79c27dd commit 7ca36c5
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@
<tag>HEAD</tag>
</scm>

<developers>
<developer>
<organization>Google</organization>
<organizationUrl>http://www.google.com</organizationUrl>
</developer>
</developers>

<issueManagement>
<system>GitHub Issues</system>
<url>https://github.com/google/gson/issues</url>
Expand Down

2 comments on commit 7ca36c5

@Marcono1234
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: The README still has the following disclaimer, so is Gson actually an 'official' Google product (whatever that means)?

gson/README.md

Lines 91 to 93 in 763e69a

### Disclaimer
This is not an officially supported Google product.

Also, should that URL use https://?

@eamonnmcmanus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I just added something quickly to satisfy the Sonatype checks. I don't know why this was suddenly necessary; perhaps because we removed the old parent POM. I think it would make sense to credit the original developers here, notably @swankjesse, @joel-leitch, and @inder123. As far as I know, they were all at Google while doing the bulk of their work, and Joel still is. So it is fair for the <organization> to be Google (and yes, probably with https). I think that is still consistent with the disclaimer.

Please sign in to comment.