Add JSON marshalling funcs for Digest. #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when you marshal a digest in a struct, you get `{}` because
all of the fields are unmarshalled. This changes the behavior to marshal
digests as their string format.
imjasonh
approved these changes
Apr 9, 2024
andrewpollock
referenced
this pull request
in google/osv-scanner
Jun 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [deps.dev/api/v3](https://togithub.com/google/deps.dev) | `v3.0.0-20240611045547-af20eef0f1eb` -> `v3.0.0-20240617015216-b147e04533eb` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [deps.dev/util/maven](https://togithub.com/google/deps.dev) | `af20eef` -> `b147e04` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [deps.dev/util/resolve](https://togithub.com/google/deps.dev) | `af20eef` -> `b147e04` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [deps.dev/util/semver](https://togithub.com/google/deps.dev) | `af20eef` -> `b147e04` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry) | `v0.19.1` -> `v0.19.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | golang.org/x/exp | `fc45aab` -> `7f521ea` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go) | `v1.34.1` -> `v1.34.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | --- ### Release Notes <details> <summary>google/go-containerregistry (github.com/google/go-containerregistry)</summary> ### [`v0.19.2`](https://togithub.com/google/go-containerregistry/releases/tag/v0.19.2) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.19.1...v0.19.2) #### What's Changed - Add JSON marshalling funcs for Digest. by [@​wlynch](https://togithub.com/wlynch) in [https://github.com/google/go-containerregistry/pull/1915](https://togithub.com/google/go-containerregistry/pull/1915) - registry: Implement Range requests for blobs by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [https://github.com/google/go-containerregistry/pull/1917](https://togithub.com/google/go-containerregistry/pull/1917) - Support podman auth file REGISTRY_AUTH_FILE. by [@​zhaoyonghe](https://togithub.com/zhaoyonghe) in [https://github.com/google/go-containerregistry/pull/1914](https://togithub.com/google/go-containerregistry/pull/1914) - feat: crane mutate platform by [@​joshwlewis](https://togithub.com/joshwlewis) in [https://github.com/google/go-containerregistry/pull/1919](https://togithub.com/google/go-containerregistry/pull/1919) - Add Context support to auth methods by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [https://github.com/google/go-containerregistry/pull/1949](https://togithub.com/google/go-containerregistry/pull/1949) - Fix windows race condition when writing image with duplicate layers by [@​dgannon991](https://togithub.com/dgannon991) in [https://github.com/google/go-containerregistry/pull/1921](https://togithub.com/google/go-containerregistry/pull/1921) - Add -O shorthand for --omit-digest-tags to crane. by [@​smoser](https://togithub.com/smoser) in [https://github.com/google/go-containerregistry/pull/1958](https://togithub.com/google/go-containerregistry/pull/1958) #### New Contributors - [@​wlynch](https://togithub.com/wlynch) made their first contribution in [https://github.com/google/go-containerregistry/pull/1915](https://togithub.com/google/go-containerregistry/pull/1915) - [@​zhaoyonghe](https://togithub.com/zhaoyonghe) made their first contribution in [https://github.com/google/go-containerregistry/pull/1914](https://togithub.com/google/go-containerregistry/pull/1914) - [@​joshwlewis](https://togithub.com/joshwlewis) made their first contribution in [https://github.com/google/go-containerregistry/pull/1919](https://togithub.com/google/go-containerregistry/pull/1919) - [@​dgannon991](https://togithub.com/dgannon991) made their first contribution in [https://github.com/google/go-containerregistry/pull/1921](https://togithub.com/google/go-containerregistry/pull/1921) - [@​smoser](https://togithub.com/smoser) made their first contribution in [https://github.com/google/go-containerregistry/pull/1958](https://togithub.com/google/go-containerregistry/pull/1958) **Full Changelog**: google/go-containerregistry@v0.19.1...v0.19.2 </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.34.2`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.34.2) [Compare Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.34.1...v1.34.2) Minor feature: - [CL/589336](https://go.dev/cl/589336): gofeatures: allow setting legacy_unmarshal_json_enum feature at file level Minor bug fixes: - [CL/588875](https://go.dev/cl/588875): types/descriptorpb: regenerate using latest protobuf v27.0 release - [CL/586396](https://go.dev/cl/586396): internal/impl: fix size cache semantics with lazy decoding - [CL/585736](https://go.dev/cl/585736): reflect/protodesc: remove obsolete JSON name check from desc validator - [CL/588976](https://go.dev/cl/588976): reflect/protoreflect: FieldDescriptor.Kind should never be GroupKind for maps or fields of map entry </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you marshal a digest, you get
{}because all of the fields are unexported (see https://go.dev/play/p/nxJQkK9qfJ3 for example).This changes the behavior to marshal digests as their string format.