-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we can access layer by diffID on a mutated image #1875
base: main
Are you sure you want to change the base?
Conversation
Previously, calling LayerByDiffID() immediately after adding a layer would error with the layer not found. By ensuring that we call "compute" on the image before trying to access the diffID map, we ensure that the layer is found. Signed-off-by: Natalie Arellano <[email protected]>
This Pull Request is stale because it has been open for 90 days with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 71.67% 71.65% -0.03%
==========================================
Files 123 123
Lines 9935 9938 +3
==========================================
Hits 7121 7121
- Misses 2115 2117 +2
- Partials 699 700 +1 ☔ View full report in Codecov by Sentry. |
@codecov-commenter I disagree! Maintainers, any opposition to merging this one? |
This Pull Request is stale because it has been open for 90 days with |
This Pull Request is stale because it has been open for 90 days with |
Previously,
calling LayerByDiffID()
immediately after adding a layer would error with the layer not found.By ensuring that we call "compute" on the image before trying to access the diffID map, we ensure that the layer is found.