feat: gcrane - Increase GCRBackoff Steps to 5 and decrease Factor to 5.0 #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
klemmari1
changed the title
klemmari1
changed the title
…go:112) breaks the loop when backoff.Steps == 1. This might cause the `gcrane cp` command to face 429 errors when we have only 2 steps to GCRBackoff because the wait period is only ~1 minute. For some reason I saw 429 errors from GCR even after a wait of 15 minutes. Do a couple of improvements to remediate this issue: - Decrease Factor to 5.0 seconds and increase steps to 6. - This way we get more retries and the maximum wait time is 1 hour after which the run will fail. - Update GCRBackoff docstring.
klemmari1
force-pushed
the
gcrane/increase-gcrbackoff-steps
branch
from
e1e7829
to
22abbb4
Compare
When cap is hit, we want to run the loop one more time before breaking out of it.
klemmari1
commented
Nov 1, 2023
| @@ -89,7 +89,7 @@ func (b *Backoff) Step() time.Duration { | |||
| b.Duration = time.Duration(float64(b.Duration) * b.Factor) | |||
| if b.Cap > 0 && b.Duration > b.Cap { | |||
| b.Duration = b.Cap | |||
| b.Steps = 0 | |||
| b.Steps = 1 | |||
There was a problem hiding this comment.
Set the Steps to 1 so that we run a final time with Duration = Cap which was not run until now.
klemmari1
changed the title
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExponentialBackoff breaks the loop when
backoff.Steps == 1. This might cause thegcrane cpcommand to fail with 429 errors when we have only 2 steps toGCRBackoffbecause the wait period is only ~1 minute.For some reason I saw 429 errors from GCR even after a wait of 15 minutes. Do a couple of improvements to remediate this issue:
Stepsto 5 to get more retries and a longer wait time on the last step.Factorto 5.0 to get more retries in a more tight schedule. Last wait time will be theCapwhich is 1 hour.b.Steps = 1whenb.Duration > b.Cap.Fix the same issue as this PR.
Fixes #424