fix: mimic oci-layout

google · Oct 11, 2023 · 2aeb32c · 2aeb32c
1 parent dbcd01c
commit 2aeb32c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/pkg/registry/blobs_disk.go b/pkg/registry/blobs_disk.go
@@ -31,7 +31,7 @@ type diskHandler struct {
 func NewDiskBlobHandler(dir string) BlobHandler { return &diskHandler{dir: dir} }
 
 func (m *diskHandler) Stat(_ context.Context, _ string, h v1.Hash) (int64, error) {
-	fi, err := os.Stat(filepath.Join(m.dir, h.String()))
+	fi, err := os.Stat(filepath.Join(m.dir, h.Algorithm, h.Hex))
 	if errors.Is(err, os.ErrNotExist) {
 		return 0, errNotFound
 	} else if err != nil {
@@ -40,7 +40,7 @@ func (m *diskHandler) Stat(_ context.Context, _ string, h v1.Hash) (int64, error
 	return fi.Size(), nil
 }
 func (m *diskHandler) Get(_ context.Context, _ string, h v1.Hash) (io.ReadCloser, error) {
-	return os.Open(filepath.Join(m.dir, h.String()))
+	return os.Open(filepath.Join(m.dir, h.Algorithm, h.Hex))
 }
 func (m *diskHandler) Put(_ context.Context, _ string, h v1.Hash, rc io.ReadCloser) error {
 	// Put the temp file in the same directory to avoid cross-device problems
@@ -57,9 +57,11 @@ func (m *diskHandler) Put(_ context.Context, _ string, h v1.Hash, rc io.ReadClos
 	}(); err != nil {
 		return err
 	}
-
-	return os.Rename(f.Name(), filepath.Join(m.dir, h.String()))
+	if err := os.MkdirAll(filepath.Join(m.dir, h.Algorithm), os.ModePerm); err != nil {
+		return err
+	}
+	return os.Rename(f.Name(), filepath.Join(m.dir, h.Algorithm, h.Hex))
 }
 func (m *diskHandler) Delete(_ context.Context, _ string, h v1.Hash) error {
-	return os.Remove(filepath.Join(m.dir, h.String()))
+	return os.Remove(filepath.Join(m.dir, h.Algorithm, h.Hex))
 }
diff --git a/pkg/registry/blobs_disk_test.go b/pkg/registry/blobs_disk_test.go
@@ -15,6 +15,7 @@
 package registry_test
 
 import (
+	"fmt"
 	"net/http/httptest"
 	"os"
 	"path/filepath"
@@ -59,7 +60,7 @@ func TestDiskPush(t *testing.T) {
 	if h, err := img.ConfigName(); err != nil {
 		t.Fatal(err)
 	} else {
-		want[h.String()] = true
+		want[fmt.Sprintf("%s/%s", h.Algorithm, h.Hex)] = true
 	}
 	ls, err := img.Layers()
 	if err != nil {
@@ -69,7 +70,7 @@ func TestDiskPush(t *testing.T) {
 		if h, err := l.Digest(); err != nil {
 			t.Fatal(err)
 		} else {
-			want[h.String()] = true
+			want[fmt.Sprintf("%s/%s", h.Algorithm, h.Hex)] = true
 		}
 	}