Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow long non-file arguments to be spilled #671

Closed
wants to merge 1 commit into from

Conversation

novalis
Copy link
Contributor

@novalis novalis commented Jul 10, 2017

Allow long non-file arguments (e.g. -classpath) to go to a file. This
prevents E2BIG when the classpath argument is too long.

This can't easily be fixed in upstream ant because:
(a) it would require an API change, and
(b) there is no way for ant to know which arguments are safe to spill
as that depends on the semantics of the external compiler.

Allow long non-file arguments (e.g. -classpath) to go to a file.  This
prevents E2BIG when the classpath argument is too long.

This can't easily be fixed in upstream ant because:
(a) it would require an API change, and
(b) there is no way for ant to know which arguments are safe to spill
as that depends on the semantics of the external compiler.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@novalis
Copy link
Contributor Author

novalis commented Jul 10, 2017

My company has signed the corporate CLA, and @googlebot has in the past gotten this correct -- see e.g. google/google-java-format#163

@novalis
Copy link
Contributor Author

novalis commented Jul 10, 2017

Oh, hm, maybe it was because I wasn't part of the Two Sigma group on github yet? Let me retry...

@novalis
Copy link
Contributor Author

novalis commented Jul 10, 2017

I signed it!

@novalis
Copy link
Contributor Author

novalis commented Aug 9, 2017

Our Google accounts were messed up, and I think are now fixed, so maybe if I retry now the CLA-bot will work?

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 9, 2017
@novalis
Copy link
Contributor Author

novalis commented Aug 24, 2017

Just a ping on this. Thanks.

ronshapiro pushed a commit that referenced this pull request Sep 6, 2017
Allow long non-file arguments (e.g. -classpath) to go to a file.  This
prevents E2BIG when the classpath argument is too long.

This can't easily be fixed in upstream ant because:
(a) it would require an API change, and
(b) there is no way for ant to know which arguments are safe to spill

Fixes #671

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=167726515
@cushon cushon mentioned this pull request Sep 6, 2017
@cushon cushon closed this in d7845cb Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants