-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow long non-file arguments to be spilled #671
Conversation
Allow long non-file arguments (e.g. -classpath) to go to a file. This prevents E2BIG when the classpath argument is too long. This can't easily be fixed in upstream ant because: (a) it would require an API change, and (b) there is no way for ant to know which arguments are safe to spill as that depends on the semantics of the external compiler.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
My company has signed the corporate CLA, and @googlebot has in the past gotten this correct -- see e.g. google/google-java-format#163 |
Oh, hm, maybe it was because I wasn't part of the Two Sigma group on github yet? Let me retry... |
I signed it! |
Our Google accounts were messed up, and I think are now fixed, so maybe if I retry now the CLA-bot will work? |
CLAs look good, thanks! |
Just a ping on this. Thanks. |
Allow long non-file arguments (e.g. -classpath) to go to a file. This prevents E2BIG when the classpath argument is too long. This can't easily be fixed in upstream ant because: (a) it would require an API change, and (b) there is no way for ant to know which arguments are safe to spill Fixes #671 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167726515
Allow long non-file arguments (e.g. -classpath) to go to a file. This
prevents E2BIG when the classpath argument is too long.
This can't easily be fixed in upstream ant because:
(a) it would require an API change, and
(b) there is no way for ant to know which arguments are safe to spill
as that depends on the semantics of the external compiler.