Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle negative timestamps on Windows #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/ee/cli/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,10 @@ def _timestamp_ms_for_datetime(datetime_obj):
def _cloud_timestamp_for_timestamp_ms(timestamp_ms):
"""Returns a Cloud-formatted date for the given millisecond timestamp."""
# Desired format is like '2003-09-07T19:30:12.345Z'
return datetime.datetime.utcfromtimestamp(
timestamp_ms / 1000.0).isoformat() + 'Z'
return (
datetime.datetime.utcfromtimestamp(0)
+ datetime.timedelta(seconds=timestamp_ms / 1000)
).isoformat() + "Z"


def _parse_millis(millis):
Expand Down